Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix NROB #437

Merged
merged 3 commits into from
Nov 23, 2022
Merged

fix NROB #437

merged 3 commits into from
Nov 23, 2022

Conversation

larshp
Copy link
Collaborator

@larshp larshp commented Nov 20, 2022 •
edited
Loading

closes #424

needs #436 to be merged first

@larshp
Copy link
Collaborator Author

larshp commented Nov 22, 2022

@schneidermic0 this is only descriptions... perhaps not perfect, but can easily be updated later if needed

@schneidermic0
Copy link
Contributor

@schneidermic0 this is only descriptions... perhaps not perfect, but can easily be updated later if needed

I have already reached out to the object type owners. I didn't get a response yet. But I agree, since it is only ABAPDoc, I think we can merge the changes

schneidermic0
schneidermic0 approved these changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@schneidermic0 schneidermic0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@schneidermic0 schneidermic0 merged commit 5dac871 into main Nov 23, 2022
@schneidermic0 schneidermic0 deleted the hvam/nrob2011 branch November 23, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schneidermic0 schneidermic0 schneidermic0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NROB: special characters in descriptions
2 participants
@larshp @schneidermic0