Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix RONT #435

Merged
merged 3 commits into from
Nov 22, 2022
Merged

fix RONT #435

merged 3 commits into from
Nov 22, 2022

Conversation

larshp
Copy link
Collaborator

@larshp larshp commented Nov 20, 2022 •
edited
Loading

closes #434

@larshp larshp marked this pull request as ready for review November 20, 2022 13:04
@larshp
Copy link
Collaborator Author

larshp commented Nov 20, 2022

needs #436 to be merged first

@schneidermic0
Copy link
Contributor

@Ehret-Thomas Would you check whether the ABAP type in the interface or the schema needs to be adapted/fixed?

Ehret-Thomas
Ehret-Thomas approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@Ehret-Thomas Ehret-Thomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this mistake in the JSON schema! The maxlength correction for the expanded name looks good to me.

@schneidermic0 schneidermic0 self-requested a review November 22, 2022 10:29
schneidermic0
schneidermic0 approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@schneidermic0 schneidermic0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schneidermic0 schneidermic0 merged commit 207865a into main Nov 22, 2022
@schneidermic0 schneidermic0 deleted the hvam/ront2011 branch November 22, 2022 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schneidermic0 schneidermic0 schneidermic0 approved these changes

@Ehret-Thomas Ehret-Thomas Ehret-Thomas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RONT: missing schema update?
3 participants
@larshp @schneidermic0 @Ehret-Thomas