Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more strict eslint, typescript rules, code clean up #95

Merged
merged 3 commits into from
Mar 21, 2023
Merged

more strict eslint, typescript rules, code clean up #95

merged 3 commits into from
Mar 21, 2023

Conversation

xdk78
Copy link
Collaborator

@xdk78 xdk78 commented Mar 20, 2023 •
edited
Loading

Resolve #81

@vercel
Copy link

vercel bot commented Mar 20, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
employee-pulse ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 21, 2023 at 6:00PM (UTC)

@xdk78 xdk78 temporarily deployed to preview March 20, 2023 18:32 — with GitHub Actions Inactive
@pmatyjasik pmatyjasik linked an issue Mar 20, 2023 that may be closed by this pull request
More stricted eslint and tsconfig #81
Closed
@xdk78 xdk78 temporarily deployed to preview March 20, 2023 18:49 — with GitHub Actions Inactive
@xdk78 xdk78 temporarily deployed to preview March 20, 2023 18:49 — with GitHub Actions Inactive
@xdk78 xdk78 requested review from Ryczko and pmatyjasik March 20, 2023 18:52
@xdk78 xdk78 marked this pull request as ready for review March 20, 2023 18:52
@xdk78 xdk78 temporarily deployed to preview March 20, 2023 18:52 — with GitHub Actions Inactive
@xdk78 xdk78 temporarily deployed to preview March 20, 2023 18:52 — with GitHub Actions Inactive
@Ryczko Ryczko temporarily deployed to preview March 21, 2023 17:59 — with GitHub Actions Inactive
@Ryczko Ryczko temporarily deployed to preview March 21, 2023 17:59 — with GitHub Actions Inactive
@Ryczko
Copy link
Owner

Ryczko commented Mar 21, 2023

I changed some rules to more convenient. Thanks for bumping React and Typescript

@Ryczko Ryczko merged commit 870afec into dev Mar 21, 2023
@Ryczko Ryczko deleted the style/more-stricter-rules branch March 21, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmatyjasik pmatyjasik pmatyjasik approved these changes

@Ryczko Ryczko Awaiting requested review from Ryczko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

More stricted eslint and tsconfig
3 participants
@xdk78 @Ryczko @pmatyjasik