Survey answer fix #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone is attempting to deploy a commit to a Personal Account owned by @Ryczko on Vercel. @Ryczko first needs to authorize it. |
Ryczko
reviewed
Mar 21, 2023
src/pages/surveys/index.tsx
Outdated
There was a problem hiding this comment.
Changes to this file are unnecessary
| @@ -28,6 +29,12 @@ function SurveyResultsPage() { | |||
| endDate, | |||
| } = useSurveyResultsManager(); | |||
|
|
|||
| const [showOnlyWrittenResponses, setShowOnlyWrittenResponses] = useState(false); | |||
|
|
|||
| const filteredAnswersData = showOnlyWrittenResponses | |||
There was a problem hiding this comment.
It is not good approach. In the given solution, filtering will take place with each rerender of the component, which will be not efficient. It's better to create person state for filteredAnswersData and update it in useEffect.
After that all logic should be moved to SurveyResultsManager
a086799 to
ec910ca
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Ryczko
approved these changes
Apr 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now it works, in the same branch as before :D it solves #78