Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change types to interfaces && fix typing #70

Merged
merged 2 commits into from
Mar 15, 2023
Merged

Change types to interfaces && fix typing #70

merged 2 commits into from
Mar 15, 2023

Conversation

pmatyjasik
Copy link
Collaborator

No description provided.

@pmatyjasik pmatyjasik added this to the 1.1 milestone Mar 15, 2023
@pmatyjasik pmatyjasik requested review from xdk78 and Ryczko March 15, 2023 18:03
@vercel
Copy link

vercel bot commented Mar 15, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
employee-pulse ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 15, 2023 at 6:28PM (UTC)

@pmatyjasik pmatyjasik temporarily deployed to preview March 15, 2023 18:03 — with GitHub Actions Inactive
@pmatyjasik pmatyjasik temporarily deployed to preview March 15, 2023 18:04 — with GitHub Actions Inactive
@pmatyjasik pmatyjasik linked an issue Mar 15, 2023 that may be closed by this pull request
Improve the consistency of the typescript #69
Closed
@xdk78
Copy link
Collaborator

xdk78 commented Mar 15, 2023

why?

@xdk78
Copy link
Collaborator

xdk78 commented Mar 15, 2023

I cannot find any advantage of interface in this code base over type
https://www.typescriptlang.org/docs/handbook/2/everyday-types.html#differences-between-type-aliases-and-interfaces

@pmatyjasik
Copy link
Collaborator Author

pmatyjasik commented Mar 15, 2023 •
edited
Loading

I cannot find any advantage of interface in this code base over type https://www.typescriptlang.org/docs/handbook/2/everyday-types.html#differences-between-type-aliases-and-interfaces

Revised to maintain consistency across files.
Some files were based on type and some on interface

@xdk78
Copy link
Collaborator

xdk78 commented Mar 15, 2023

I cannot find any advantage of interface in this code base over type https://www.typescriptlang.org/docs/handbook/2/everyday-types.html#differences-between-type-aliases-and-interfaces

Revised to maintain consistency across files. Some files were based on type and some on interface

ok

@pmatyjasik pmatyjasik temporarily deployed to preview March 15, 2023 18:28 — with GitHub Actions Inactive
@pmatyjasik pmatyjasik temporarily deployed to preview March 15, 2023 18:28 — with GitHub Actions Inactive
@pmatyjasik pmatyjasik merged commit aa7f629 into dev Mar 15, 2023
@pmatyjasik pmatyjasik deleted the fix/typescript-typing branch March 15, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xdk78 xdk78 xdk78 approved these changes

@Ryczko Ryczko Awaiting requested review from Ryczko

Assignees
No one assigned
Labels
technical
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging this pull request may close these issues.

Improve the consistency of the typescript
2 participants
@pmatyjasik @xdk78