Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare account deletion #67

Merged
merged 13 commits into from
Mar 20, 2023
Merged

Prepare account deletion #67

merged 13 commits into from
Mar 20, 2023

Conversation

xdk78
Copy link
Collaborator

@xdk78 xdk78 commented Mar 15, 2023

Resolve #51

@xdk78 xdk78 temporarily deployed to preview March 15, 2023 12:19 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented Mar 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
employee-pulse ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 20, 2023 at 4:29PM (UTC)

@xdk78 xdk78 temporarily deployed to preview March 15, 2023 12:19 — with GitHub Actions Inactive
@xdk78 xdk78 requested review from pmatyjasik and Ryczko March 15, 2023 12:19
@xdk78 xdk78 added the new feature New feature or request label Mar 15, 2023
src/layout/Navigation/Navigation.tsx Show resolved Hide resolved
src/pages/settings/index.tsx Outdated Show resolved Hide resolved
src/pages/settings/index.tsx Outdated Show resolved Hide resolved
src/pages/settings/index.tsx Outdated Show resolved Hide resolved
src/layout/Navigation/Navigation.tsx Show resolved Hide resolved
@xdk78 xdk78 temporarily deployed to preview March 15, 2023 17:30 — with GitHub Actions Inactive
@xdk78 xdk78 temporarily deployed to preview March 15, 2023 17:30 — with GitHub Actions Inactive
@xdk78 xdk78 temporarily deployed to preview March 15, 2023 17:48 — with GitHub Actions Inactive
@xdk78 xdk78 temporarily deployed to preview March 15, 2023 17:48 — with GitHub Actions Inactive
@xdk78 xdk78 temporarily deployed to preview March 15, 2023 18:01 — with GitHub Actions Inactive
@xdk78 xdk78 temporarily deployed to preview March 15, 2023 18:01 — with GitHub Actions Inactive
@xdk78 xdk78 temporarily deployed to preview March 16, 2023 18:14 — with GitHub Actions Inactive
@xdk78 xdk78 temporarily deployed to preview March 16, 2023 18:14 — with GitHub Actions Inactive
@xdk78 xdk78 temporarily deployed to preview March 18, 2023 16:43 — with GitHub Actions Inactive
@xdk78 xdk78 temporarily deployed to preview March 18, 2023 16:43 — with GitHub Actions Inactive
@xdk78 xdk78 marked this pull request as ready for review March 18, 2023 16:43
@xdk78 xdk78 requested a review from Ryczko March 19, 2023 11:32
Copy link
Owner

@Ryczko Ryczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 problems has been found:

  • Sometimes on my surveys page when you click delete button and then cancel on modal, all page is blocked (nothing can be clicked)
screen-capture.1.webm
  • 'Delete my account' button jumps when modal is opened.
screen-capture.2.webm
  • When settings button is hover it should takes all width on mobile and desktop:
    image
    image

@xdk78 xdk78 temporarily deployed to preview March 19, 2023 18:25 — with GitHub Actions Inactive
@xdk78 xdk78 temporarily deployed to preview March 19, 2023 18:25 — with GitHub Actions Inactive
@xdk78 xdk78 temporarily deployed to preview March 19, 2023 18:27 — with GitHub Actions Inactive
@xdk78 xdk78 temporarily deployed to preview March 19, 2023 18:27 — with GitHub Actions Inactive
@xdk78 xdk78 temporarily deployed to preview March 19, 2023 18:32 — with GitHub Actions Inactive
@xdk78 xdk78 temporarily deployed to preview March 19, 2023 18:32 — with GitHub Actions Inactive
@xdk78 xdk78 requested a review from Ryczko March 19, 2023 18:34
src/pages/settings/index.tsx Outdated Show resolved Hide resolved
src/pages/settings/index.tsx Outdated Show resolved Hide resolved
@xdk78 xdk78 temporarily deployed to preview March 20, 2023 10:59 — with GitHub Actions Inactive
@xdk78 xdk78 temporarily deployed to preview March 20, 2023 10:59 — with GitHub Actions Inactive
@xdk78 xdk78 temporarily deployed to preview March 20, 2023 12:26 — with GitHub Actions Inactive
@xdk78 xdk78 temporarily deployed to preview March 20, 2023 12:29 — with GitHub Actions Inactive
@xdk78 xdk78 temporarily deployed to preview March 20, 2023 12:29 — with GitHub Actions Inactive
@xdk78 xdk78 requested a review from pmatyjasik March 20, 2023 13:55
@Ryczko Ryczko temporarily deployed to preview March 20, 2023 16:28 — with GitHub Actions Inactive
@Ryczko Ryczko temporarily deployed to preview March 20, 2023 16:28 — with GitHub Actions Inactive
@Ryczko Ryczko merged commit 50c9619 into dev Mar 20, 2023
@Ryczko Ryczko deleted the feat/delete-account branch March 20, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the ability to delete an account
3 participants