Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new date picker + time picker + minor sign out button too big fix #37

Merged
merged 8 commits into from
May 12, 2022
Merged

new date picker + time picker + minor sign out button too big fix #37

merged 8 commits into from
May 12, 2022

Conversation

Luberski
Copy link
Contributor

  • Nowy date picker dostosowany do naszego wyglądu
  • Time picker
  • Zablokowane wybieranie poprzednich dni
  • Zmniejszyłem sign out button bo był jakiś super duży

@Luberski Luberski requested review from xdk78 and Ryczko May 11, 2022 19:03
@vercel
Copy link

vercel bot commented May 11, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
employee-pulse ✅ Ready (Inspect) Visit Preview May 12, 2022 at 9:57AM (UTC)

@Luberski Luberski marked this pull request as ready for review May 11, 2022 19:05
xdk78
xdk78 reviewed May 11, 2022
View reviewed changes
src/datepicker.scss Outdated Show resolved Hide resolved
xdk78
xdk78 reviewed May 11, 2022
View reviewed changes
src/datepicker.scss Outdated Show resolved Hide resolved
xdk78
xdk78 reviewed May 11, 2022
View reviewed changes
src/datepicker.scss Outdated Show resolved Hide resolved
xdk78
xdk78 requested changes May 11, 2022
View reviewed changes
Copy link
Collaborator

@xdk78 xdk78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kolorki zmień

xdk78
xdk78 requested changes May 11, 2022
View reviewed changes
Copy link
Collaborator

@xdk78 xdk78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing lib

@pmatyjasik
Copy link
Collaborator

pmatyjasik commented May 11, 2022 •
edited
Loading

Cała logika działa spoko, kilka błędów:

  • chyba różnica czcionek
  • dziwne kolory przy wyborze godziny
  • kalendarz mógłby być zaokrąglony
  • mobilka dziwnie działa.

Ogólnie wygląda jak z innej parafii

image

@Ryczko
Copy link
Owner

Ryczko commented May 11, 2022

Cała logika działa spoko, kilka błędów:

  • chyba różnica czcionek
  • dziwne kolory przy wyborze godziny
  • kalendarz mógłby być zaokrąglony
  • mobilka dziwnie działa.

Ogólnie wygląda jak z innej parafii

image

@pmatyjasik ma rację. Trzeba to zrobić porządnie, żeby cała aplikacja była spójna.

@Ryczko Ryczko merged commit 5652013 into dev May 12, 2022
@Ryczko Ryczko deleted the feature/new_date_picker branch May 12, 2022 10:08
Ryczko added a commit that referenced this pull request Feb 8, 2023
@Ryczko
Merge pull request #37 from Ryczko/feature/new_date_picker
ad5018f 
new date picker + time picker + minor sign out button too big fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xdk78 xdk78 xdk78 approved these changes

@Ryczko Ryczko Awaiting requested review from Ryczko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Luberski @pmatyjasik @Ryczko @xdk78