Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: added survey share modal #220

Merged
merged 3 commits into from
Aug 24, 2023
Merged

Feat: added survey share modal #220

merged 3 commits into from
Aug 24, 2023

Conversation

shubhamku044
Copy link
Contributor

image

image

@vercel
Copy link

vercel bot commented Aug 23, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @Ryczko on Vercel.

@Ryczko first needs to authorize it.

@shubhamku044 shubhamku044 mentioned this pull request Aug 23, 2023
Comment on lines 41 to 42
<p className="text-sm text-red-500">
</p>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will not have error field here, so you can remove it.

copy(link);
}}
icon={<LinkIcon className="h-5 w-5" />}
className=""
Copy link
Owner

@Ryczko Ryczko Aug 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty className to remove

Copy link
Owner

@Ryczko Ryczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contribution 😊 Small notes

@Ryczko Ryczko linked an issue Aug 23, 2023 that may be closed by this pull request
variant={ButtonVariant.PRIMARY}
className="w-full justify-center sm:mb-0 sm:w-[260px]"
className="w-full justify-center gap-1 sm:mb-0 sm:w-[260px]"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove sm:w-[260px] to get rid of big paddings

@shubhamku044
Copy link
Contributor Author

Sure, will do all the changes.

@vercel
Copy link

vercel bot commented Aug 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
formslab ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 24, 2023 2:54pm

@Ryczko Ryczko merged commit 582e101 into Ryczko:dev Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Share survey modal
2 participants