Load survey answers data from backend #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xdk78
requested changes
Apr 23, 2022
| }, [surveyId]); | ||
|
|
||
| const getSurveyData = async () => { | ||
| const surveyData = await getDoc(doc(db, 'surveys', surveyId!)); |
There was a problem hiding this comment.
surveyId! typescript płacze o to.
można po prostu zrobić tak jak tu: https://github.com/Ryczko/Employee-pulse/blob/95cd3d4bc8914ec78cd9019e6371d5b280e60e1c/src/Pages/SurveyPage/index.tsx#L32
There was a problem hiding this comment.
Nie płacze, tak to unikamy redundancji kodu kilka linijek wyżej, świadomie to jest użyte i nie ma opcji żeby to było null lub undefined. Ja bym zostawił
There was a problem hiding this comment.
There was a problem hiding this comment.
najwyżej po prostu wyłącz ten rule w configu eslinta jak chcesz
| return; | ||
| } | ||
| const surveyData = await getDoc(doc(db, 'surveys', surveyId)); | ||
| const surveyData = await getDoc(doc(db, 'surveys', surveyId!)); |
There was a problem hiding this comment.
git było, typescript znowu płacze 😢
Ryczko
added a commit
that referenced
this pull request
Feb 8, 2023
Load survey answers data from backend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.