Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feat): Ability to enable and disable a survey #130

Merged
merged 3 commits into from
Apr 4, 2023
Merged

(feat): Ability to enable and disable a survey #130

merged 3 commits into from
Apr 4, 2023

Conversation

NiazMorshed2007
Copy link
Contributor

This pr introduces a new feature of enabling users to activate or deactivate the survey, described in #129

@vercel
Copy link

vercel bot commented Apr 1, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @Ryczko on Vercel.

@Ryczko first needs to authorize it.

@NiazMorshed2007 NiazMorshed2007 temporarily deployed to preview April 1, 2023 17:52 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented Apr 2, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
employee-pulse ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2023 6:35pm

@NiazMorshed2007 NiazMorshed2007 temporarily deployed to preview April 2, 2023 08:51 — with GitHub Actions Inactive
Ryczko
Ryczko requested changes Apr 2, 2023
View reviewed changes
Copy link
Owner

@Ryczko Ryczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution to Employee Pulse. We appreciate it very much! 🥳
A few notes on your changes.

src/features/surveys/managers/surveyAnswerManager.ts Outdated Show resolved Hide resolved
src/features/surveys/managers/surveyResultsManager.ts Show resolved Hide resolved
src/pages/survey/[surveyId]/index.tsx Outdated Show resolved Hide resolved
src/features/surveys/managers/surveyAnswerManager.ts Show resolved Hide resolved
src/pages/survey/[surveyId]/index.tsx Show resolved Hide resolved
@NiazMorshed2007 NiazMorshed2007 temporarily deployed to preview April 2, 2023 10:56 — with GitHub Actions Inactive
@Ryczko Ryczko force-pushed the feat-survey-status branch from b647da9 to 924aae0 Compare April 4, 2023 18:33
@Ryczko Ryczko temporarily deployed to preview April 4, 2023 18:34 — with GitHub Actions Inactive
@Ryczko Ryczko temporarily deployed to preview April 4, 2023 18:34 — with GitHub Actions Inactive
@Ryczko
Copy link
Owner

Ryczko commented Apr 4, 2023

Great job, thanks! 👏

@Ryczko Ryczko merged commit e173531 into Ryczko:dev Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ryczko Ryczko Ryczko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NiazMorshed2007 @Ryczko