Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This pull request addresses the issue of Validation on answer page #124 #127

Merged
merged 3 commits into from
Apr 2, 2023
Merged

This pull request addresses the issue of Validation on answer page #124 #127

merged 3 commits into from
Apr 2, 2023

Conversation

phootako630
Copy link
Contributor

The changes I made include removing buttonDisable and adding a useState hook to get emoji error.

@phootako630
This pull request addresses the issue of Validation on answer page Ry…
77fe825 
…czko#124

The changes I made include removing buttonDisable and adding a useState hook to get emoji error.
@vercel
Copy link

vercel bot commented Mar 31, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @Ryczko on Vercel.

@Ryczko first needs to authorize it.

@phootako630 phootako630 temporarily deployed to preview March 31, 2023 21:34 — with GitHub Actions Inactive
@phootako630
Copy link
Contributor Author

It goes like this when users click the send button without selected icons:
image

@vercel
Copy link

vercel bot commented Apr 1, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
employee-pulse ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2023 8:49am

@phootako630 phootako630 temporarily deployed to preview April 1, 2023 08:48 — with GitHub Actions Inactive
@Ryczko Ryczko linked an issue Apr 1, 2023 that may be closed by this pull request
Validation on answer page #124
Closed
Ryczko
Ryczko requested changes Apr 1, 2023
View reviewed changes
Copy link
Owner

@Ryczko Ryczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Thank you for your contribution 🎉
One small thing. Error should disappear when user selected emoji. Please add setShowEmojiError(false); to handleIconClick 😊

@phootako630
Copy link
Contributor Author

Thanks for pointing out the problem. I will correct it asap.

@phootako630
This pull request addresses the issue of Validation on answer page Ry…
61036ac 
…czko#124

The changes I made include removing buttonDisable and adding a useState hook to get emoji error.
@phootako630
Merge remote-tracking branch 'origin/dev' into dev
ca54d0d
@phootako630 phootako630 temporarily deployed to preview April 1, 2023 20:21 — with GitHub Actions Inactive
@phootako630 phootako630 requested a review from Ryczko April 1, 2023 20:22
@phootako630 phootako630 temporarily deployed to preview April 2, 2023 08:48 — with GitHub Actions Inactive
@Ryczko Ryczko merged commit 3186bea into Ryczko:dev Apr 2, 2023
@phootako630 phootako630 temporarily deployed to preview April 2, 2023 23:21 — with GitHub Actions Inactive
@phootako630 phootako630 temporarily deployed to preview April 2, 2023 23:21 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ryczko Ryczko Ryczko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validation on answer page
2 participants
@phootako630 @Ryczko