Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/Add toggle component #125

Merged
merged 2 commits into from
Mar 31, 2023
Merged

Feature/Add toggle component #125

merged 2 commits into from
Mar 31, 2023

Conversation

Ryczko
Copy link
Owner

@Ryczko Ryczko commented Mar 30, 2023

image

@vercel
Copy link

vercel bot commented Mar 30, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
employee-pulse ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 31, 2023 at 3:19PM (UTC)

@Ryczko Ryczko temporarily deployed to preview March 30, 2023 16:59 — with GitHub Actions Inactive
@Ryczko Ryczko temporarily deployed to preview March 30, 2023 16:59 — with GitHub Actions Inactive
xdk78
xdk78 requested changes Mar 30, 2023
View reviewed changes
Copy link
Collaborator

@xdk78 xdk78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add unit tests for this component?

@Ryczko Ryczko temporarily deployed to preview March 31, 2023 15:19 — with GitHub Actions Inactive
@Ryczko Ryczko temporarily deployed to preview March 31, 2023 15:19 — with GitHub Actions Inactive
@Ryczko
Copy link
Owner Author

Ryczko commented Mar 31, 2023

I also removed running tests on pre-commit, because it can take a long time and be annoying. We have Github actions for this

@Ryczko Ryczko requested a review from xdk78 March 31, 2023 15:20
@Ryczko Ryczko merged commit ab5c3da into dev Mar 31, 2023
@Ryczko Ryczko deleted the feature/create-toggle-switch branch March 31, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xdk78 xdk78 xdk78 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ryczko @xdk78