Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/customize emoji amount #121

Merged
merged 10 commits into from
Apr 7, 2023
Merged

Feature/customize emoji amount #121

merged 10 commits into from
Apr 7, 2023

Conversation

a-lukasiewicz
Copy link
Collaborator

No description provided.

@a-lukasiewicz a-lukasiewicz requested a review from Ryczko March 29, 2023 15:26
@a-lukasiewicz a-lukasiewicz self-assigned this Mar 29, 2023
@vercel
Copy link

vercel bot commented Mar 29, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
employee-pulse ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 7, 2023 7:05pm

@a-lukasiewicz a-lukasiewicz linked an issue Mar 29, 2023 that may be closed by this pull request
Customize emojis amount in survey #113
Closed
@pmatyjasik
Copy link
Collaborator

pmatyjasik commented Mar 29, 2023 •
edited
Loading

  • Add Toast when new emoji is duplicated
  • I think that horizontal scroll is bad for UX&UI (Maybe make grid with 4 columns in one line?)

@a-lukasiewicz a-lukasiewicz temporarily deployed to preview March 30, 2023 06:17 — with GitHub Actions Inactive
@a-lukasiewicz a-lukasiewicz temporarily deployed to preview March 30, 2023 06:17 — with GitHub Actions Inactive
@a-lukasiewicz
Copy link
Collaborator Author

Ready to be checked @pmatyjasik @Ryczko

@pmatyjasik
Copy link
Collaborator

pmatyjasik commented Mar 30, 2023 •
edited
Loading

Fix mobile view under 350px
CleanShot 2023-03-30 at 09 57 48@2x

@a-lukasiewicz a-lukasiewicz temporarily deployed to preview March 30, 2023 08:48 — with GitHub Actions Inactive
@a-lukasiewicz a-lukasiewicz temporarily deployed to preview March 30, 2023 08:48 — with GitHub Actions Inactive
@a-lukasiewicz
Copy link
Collaborator Author

a-lukasiewicz commented Mar 30, 2023 •
edited
Loading

Fix mobile view under 350px CleanShot 2023-03-30 at 09 57 48@2x

Fixed
image

@pmatyjasik pmatyjasik self-requested a review March 30, 2023 08:53
@Ryczko Ryczko temporarily deployed to preview March 30, 2023 15:54 — with GitHub Actions Inactive
@Ryczko Ryczko temporarily deployed to preview March 30, 2023 15:54 — with GitHub Actions Inactive
@a-lukasiewicz a-lukasiewicz temporarily deployed to preview April 3, 2023 16:12 — with GitHub Actions Inactive
@a-lukasiewicz a-lukasiewicz temporarily deployed to preview April 3, 2023 16:12 — with GitHub Actions Inactive
@a-lukasiewicz a-lukasiewicz requested a review from Ryczko April 3, 2023 16:16
@Ryczko Ryczko force-pushed the feature/customize-emoji-amount branch from 8f0a953 to 3925406 Compare April 7, 2023 19:04
@Ryczko Ryczko temporarily deployed to preview April 7, 2023 19:05 — with GitHub Actions Inactive
@Ryczko Ryczko temporarily deployed to preview April 7, 2023 19:05 — with GitHub Actions Inactive
@Ryczko Ryczko merged commit 4cd7ab8 into dev Apr 7, 2023
@Ryczko Ryczko deleted the feature/customize-emoji-amount branch April 7, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmatyjasik pmatyjasik pmatyjasik approved these changes

@Ryczko Ryczko Ryczko approved these changes

Assignees

@a-lukasiewicz a-lukasiewicz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Customize emojis amount in survey
3 participants
@a-lukasiewicz @pmatyjasik @Ryczko