Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change regex and error #109

Merged
merged 3 commits into from
Mar 25, 2023
Merged

Change regex and error #109

merged 3 commits into from
Mar 25, 2023

Conversation

pmatyjasik
Copy link
Collaborator

No description provided.

@pmatyjasik pmatyjasik requested a review from Ryczko March 24, 2023 18:23
@vercel
Copy link

vercel bot commented Mar 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
employee-pulse ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 25, 2023 at 6:18PM (UTC)

@pmatyjasik pmatyjasik temporarily deployed to preview March 24, 2023 18:24 — with GitHub Actions Inactive
@pmatyjasik pmatyjasik temporarily deployed to preview March 24, 2023 18:24 — with GitHub Actions Inactive
Copy link
Collaborator

@xdk78 xdk78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Limiting password length like that is not good idea. Increase it at least to 64 chars

@pmatyjasik pmatyjasik temporarily deployed to preview March 25, 2023 12:51 — with GitHub Actions Inactive
@pmatyjasik pmatyjasik temporarily deployed to preview March 25, 2023 12:51 — with GitHub Actions Inactive
@Ryczko
Copy link
Owner

Ryczko commented Mar 25, 2023

If we are validate only length we can remove regex and use YUP validators. We should also have separated messages for too long and too short passwords

@Ryczko Ryczko temporarily deployed to preview March 25, 2023 18:18 — with GitHub Actions Inactive
@Ryczko Ryczko temporarily deployed to preview March 25, 2023 18:18 — with GitHub Actions Inactive
@Ryczko Ryczko merged commit 8362e0b into dev Mar 25, 2023
@Ryczko Ryczko deleted the fix/singup-password branch March 25, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants