Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifies the watch OS deployment target to align with RXSwift #177

Merged
merged 1 commit into from
Feb 12, 2019
Merged

Modifies the watch OS deployment target to align with RXSwift #177

merged 1 commit into from
Feb 12, 2019

Conversation

debriennefrancoisjean
Copy link

In order to build Action (specifically the Action-WatchOS target) with the latest RXSwift, we need to upgrade the minimum deployment target of Action-WatchOS to 3.0 (from 2.0).

This fixes carthage build issues when installing Action

@debriennefrancoisjean
Copy link
Author

This references original issue #173

Copy link
Member

@ashfurrow ashfurrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@ashfurrow ashfurrow merged commit 9377dee into RxSwiftCommunity:master Feb 12, 2019
@rxswiftcommunity
Copy link

Thanks a lot for contributing @debriennefrancoisjean! I've invited you to join the
RxSwiftCommunity GitHub organization – no pressure to accept! If you'd like
more information on what this means, check out our contributor guidelines
and feel free to reach out with any questions.

Generated by 🚫 dangerJS

@ashfurrow
Copy link
Member

I've released this patch (for Carthage only, since it won't affect CocoaPods) as 3.10.1. Let me know how it goes, and thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants