Enable setting headers on RemoteLRS.queryStatements
#67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@garemoko care to review? |
|
Code looks good. Would be nice to include a test. |
|
The test would go around here: #67 I'm thinking we set the X-Experience-API-Version to "11" and test for a 400 response. |
|
Tests would be good, but at this point I'm trying to get all of the things in, honestly I think to get better coverage in this lib we need to switch to mocking the LRS or the HTTP request, and that is a much bigger task than I'm willing (or able) to take on at the moment. |
|
Cool. If I get some time this week I might add the test I suggested as a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26.