crypto-bigint: add modulo operations to UInt
#561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bc9c95a to
77a60c5
Compare
6774279 to
1256d09
Compare
1256d09 to
63e6751
Compare
|
Added some trait wrappers in 2b37f48. A couple notes:
Ideally we can eventually replace that with |
Implements - `add_mod` - `sub_mod` - `neg_mod` for `UInt<1..=4>` manually
Switches to a fully generic implementation, splits out tests macros, and fixes builds on 32-bit targets.
Currently failing
2b37f48 to
54a3c47
Compare
|
@dignifiedquire I tried to write a proptest for https://github.com/RustCrypto/utils/pull/561/checks?check_run_id=3196567313 However the code looks correct to me, so I'm not sure if there's something wrong with the test itself or the code. |
Not working
bcbba92 to
f6f545f
Compare
UInt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing on @dignifiedquire's work from #510, this PR attempts to simplify the implementation.
Aspirationally, the goal is to add equivalence tests with a known-good implementation.Proptests againstnum-bigintadded.