cryptography: add std feature
#317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23da3d4 to
ff86f95
Compare
Adds an off-by-default `std` feature which activates the `std` features of all of the other dependencies. This is a somewhat lousy way of doing this, and I wish that there were a better approach, so much that I posted a Pre-Pre-RFC about it: https://internals.rust-lang.org/t/pre-pre-rfc-weak-cargo-feature-activation/13141 For now though, this is immediately useful to me.
ff86f95 to
d162162
Compare
newpavlov
approved these changes
Sep 30, 2020
Merged
dns2utf8
pushed a commit
to dns2utf8/traits
that referenced
this pull request
Jan 24, 2023
This version added a check that encoded Base64 is canonical, i.e. that the decoded value will round-trip back to the encoded value. Some of the test vectors did not have this property and have been fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an off-by-default
stdfeature which activates thestdfeatures of all of the other dependencies.This is a somewhat lousy way of doing this, and I wish that there were a better approach, so much that I posted a Pre-Pre-RFC about it:
https://internals.rust-lang.org/t/pre-pre-rfc-weak-cargo-feature-activation/13141
Edit: seems there's an open issue about this already:
rust-lang/cargo#3494
For now though, this is immediately useful to me.