ecdsa: optimize trial_recovery_from_prehash using recover_from_prehash_noverify
#832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this would probably also benefit from the |
tarcieri
reviewed
Jul 25, 2024
ecdsa/src/recovery.rs
Outdated
Comment on lines
146
to
150
| verify_prehashed::<C>( | ||
| &ProjectivePoint::<C>::from(*vk.as_affine()), | ||
| &bits2field::<C>(prehash)?, | ||
| signature, | ||
| )?; |
There was a problem hiding this comment.
You could also do this first thing since you already have the key and signature
…hash_noverify` verifying the public key on each attempt is unnecessary. Just verify once.
7dd9cc2 to
f49277a
Compare
tarcieri
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the recovered public key is eventually authenticated through comparison, verifying the public key on each attempt is unnecessary.