Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If someone tries to use, e.g.
serde_json
as a serialization library with crypto-bigintUInt
s, currently this fails at runtime:This arises from the
serdect
dependency. There's currently no way to pass thealloc
flag down through crypto-bigint.The proposed solution here just piggybacks on the crypto-bigint
alloc
flag to also pass it down toserdect
, but only if that dependency has been realized. Another option would be to always always enableserdect/alloc
whenserde
is requested:or offer a new feature altogether to keep all the user's options open:
I think my changes here make the most sense, but let me know if you prefer one of those other options, or something I haven't thought of.