Add more intrinsics and refactor how we implement them #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would appreciate any GCC folks looking at this. This is part of my set of patches to get slices working, just so you know for context. It would be easier to look at each individual commit rather than the full diff for reviewing purposes. |
CohenArthur
reviewed
Mar 10, 2022
d3eeed8 to
7679cbe
Compare
This patch adds the initial support for generic intrinsics these are do not map directly to GCC builtins and need to be substited with their specificed types. This patch allows for custom implementation body for these functions by specifying handler functions which will generate the applicable intrinsic when asked for. Addresses #658
Intrinsics were hidden behind the GCC abstract. This removes it by keeping all of this logic within rust-intrinsic.cc so that we can make mappings of the rustc name to GCC ones. We have a big comment from the mappings used over to LLVM builtins which we can use to help guide how we do this for GCC.
This demonstrates how we can add in the simple intrinsics in a single patch. Addresses #658
Addresses #658
This is another type of intrisic since the function contains no parameters but the argument for the size_of is the generic parameter T. Which uses TYPE_SIZE_UNIT to get the type size in bytes. GCC will optimize the function call away when you turn optimizations on. Addresses #658
7679cbe to
f057445
Compare
CohenArthur
approved these changes
Mar 10, 2022
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch series implements:
It removes the GCC wrapper mappings to make them much easier to implement. It also demonstrates in single commits
the implementation of each of these intrinsic to make it easy to follow in how we implement them.
Addresses #658 #849