Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Our team #11

Merged
merged 3 commits into from
Nov 18, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 9 additions & 19 deletions mukomelov.md
Original file line number Diff line number Diff line change
@@ -1,30 +1,20 @@
Changelog

- удалил темплейтовые картинки
- удалил main.css файл (видимо остался с прошлого проекта)
- убрал (закомментировал, но лучше удалить) скрипты кпопки вверх и модалки
- !предложение! удалить js кнопки и модалки чтоб не путали (файлы с прошлого
проекта)
- Устанавливает плагин basiclightbox
- Добавляет модалку с членами команды через basiclightbox
- Добавляет классы в элемент футера для зацепки через js и минимальной
стилизации (подчеркивание, тип курсора - подсказка пользователю о
кликабельности элемента)
- js добавлен в оба корневых файла - index.js, library.js (иначе не
подхватывает)

scss
---

- добавлены переменные (\_variables)

html

- создана страница library.html

js
чтоб не забыть:

- создан library.js как входной файл для раздачи css на отдельную страницу.
нюанс парсела, в то время как сборка js шерится между страницами, но css нет.
В страницу библиотеки подключен library как обходной путь для привязки css,
index должен раздавать js на обе страницы. проверим.
https://github.com/parcel-bundler/parcel/issues/2340
- то же самое по modal.html

задачи по проекту

- реализована адаптивная верстка и стилизация хедеров основной страницы,
библиотеки, модального окна
- modal.html создано временно для визуализации отрисовки хедера на модалке.
3 changes: 2 additions & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 2 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,12 @@
"url": "https://github.com/goitacademy/parcel-project-template/issues"
},
"devDependencies": {
"basiclightbox": "^5.0.3",
"gh-pages": "^3.1.0",
"parcel-bundler": "^1.12.4",
"parcel-plugin-handlebars-precompile": "^1.0.2",
"posthtml-include": "^1.6.0",
"sass": "^1.26.9"
},
"dependencies": {
"basiclightbox": "^5.0.3"
}
"dependencies": {}
}
1 change: 1 addition & 0 deletions src/images/sprite.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added src/images/team-aleksandr.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added src/images/team-daria.jpeg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added src/images/team-denis.jpeg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added src/images/team-ihor.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added src/images/team-katya.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added src/images/team-olga.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added src/images/team-ruslana.jpeg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added src/images/team-vladymyr.jpeg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
11 changes: 7 additions & 4 deletions src/index.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
import "./sass/main.scss";
import "./js/modalFilmCard.js";
import "./js/modalOpen.js";
import "./js/cardFetc.js";
import './sass/main.scss';
import './js/modalFilmCard.js';
import './js/modalOpen.js';
import './js/cardFetc.js';
import './js/teamLightbox';
import "./js/pagination.js";
import '../node_modules/basiclightbox/dist/basicLightbox.min.css';

87 changes: 87 additions & 0 deletions src/js/teamLightbox.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,87 @@
import * as basicLightbox from 'basiclightbox';
import ruslanaUrl from '../images/team-ruslana.jpeg';
import olgaUrl from '../images/team-olga.jpg';
import dariaUrl from '../images/team-daria.jpeg';
import denisUrl from '../images/team-denis.jpeg';
import ihorUrl from '../images/team-ihor.jpg';
import katyaUrl from '../images/team-katya.jpg';
import vladymyrUrl from '../images/team-vladymyr.jpeg';
import aleksandrUrl from '../images/team-aleksandr.jpg';
import spriteUrl from '../images/sprite.svg';

const markup = `<div class="team-wrapper"><div class="team-card">
<img src="${ruslanaUrl}" alt="Ruslana" class="team-image">
<p class="team-name">Ruslana</p>
<p class="team-role">Team Leader</p>
<a href="https://github.com/RuslanaLogosha" target="_blank" class="team-git"><svg class="logo__icon" width="24" height="24">
<use href="${spriteUrl}#github"></use>
</svg></a>
</div>
<div class="team-card">
<img src="${olgaUrl}" alt="Olga" class="team-image">
<p class="team-name">Olga</p>
<p class="team-role">Scrum Master</p>
<a href="https://github.com/levshukova" target="_blank" class="team-git"><svg class="logo__icon" width="24" height="24">
<use href="${spriteUrl}#github"></use>
</svg></a>
</div>
<div class="team-card">
<img src="${dariaUrl}" alt="Daria" class="team-image">
<p class="team-name">Daria</p>
<p class="team-role">Developer</p>
<a href="https://github.com/Daria-Churkina" target="_blank" class="team-git"><svg class="logo__icon" width="24" height="24">
<use href="${spriteUrl}#github"></use>
</svg></a>
</div>
<div class="team-card">
<img src="${denisUrl}" alt="Denis" class="team-image">
<p class="team-name">Denis</p>
<p class="team-role">Developer</p>
<a href="https://github.com/" target="_blank" class="team-git"><svg class="logo__icon" width="24" height="24">
<use href="${spriteUrl}#github"></use>
</svg></a>
</div>
<div class="team-card">
<img src="${ihorUrl}" alt="Ihor" class="team-image">
<p class="team-name">Ihor</p>
<p class="team-role">Developer</p>
<a href="https://github.com/taraiihor" target="_blank" class="team-git"><svg class="logo__icon" width="24" height="24">
<use href="${spriteUrl}#github"></use>
</svg></a>
</div>
<div class="team-card">
<img src="${katyaUrl}" alt="Katya" class="team-image">
<p class="team-name">Katya</p>
<p class="team-role">Developer</p>
<a href="https://github.com/Kateryna-Urbanovych" target="_blank" class="team-git"><svg class="logo__icon" width="24" height="24">
<use href="${spriteUrl}#github"></use>
</svg></a>
</div>
<div class="team-card">
<img src="${vladymyrUrl}" alt="Vladymyr" class="team-image">
<p class="team-name">Vladymyr</p>
<p class="team-role">Developer</p>
<a href="https://github.com/created-with-love" target="_blank" class="team-git"><svg class="logo__icon" width="24" height="24">
<use href="${spriteUrl}#github"></use>
</svg></a>
</div>
<div class="team-card">
<img src="${aleksandrUrl}" alt="Aleksandr" class="team-image">
<p class="team-name">Aleksandr</p>
<p class="team-role">Developer</p>
<a href="https://github.com/AleksMkm" target="_blank" class="team-git"><svg class="logo__icon" width="24" height="24">
<use href="${spriteUrl}#github"></use>
</svg></a>
</div></div>`;
const container = document.querySelector('.js-team-modal');
const markup2 = `<img src="${katyaUrl}"/>`;

container.addEventListener('click', openModal);

function teamModalWindow(data) {
return basicLightbox.create(data);
}

function openModal(e) {
teamModalWindow(markup).show();
}
1 change: 1 addition & 0 deletions src/library.html
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
</head>
<body>
<include src="./partials/header-library.html"></include>
<include src="./partials/footer.html"></include>
<script src="./library.js"></script>
</body>
</html>
2 changes: 2 additions & 0 deletions src/library.js
Original file line number Diff line number Diff line change
@@ -1 +1,3 @@
import './sass/main.scss';
import './js/teamLightbox';
import '../node_modules/basiclightbox/dist/basicLightbox.min.css';
25 changes: 14 additions & 11 deletions src/partials/footer.html
Original file line number Diff line number Diff line change
@@ -1,13 +1,16 @@
<footer>
<div class="container">
<div class="page__footer">
<p class="copyright">&copy; 2020 | All Rights Reserved |&nbsp; </p>
<div class=developers>
<p>Developed with</p>
<img src='./images/orange-heart.svg' alt='иконка сердечка' class="footer__image">
<p>by GoIT Students</p>
</div>
</div>
<div class="container">
<div class="page__footer">
<p class="copyright">&copy; 2020 | All Rights Reserved |&nbsp;</p>
<div class="developers">
<p>Developed with</p>
<img
src="./images/orange-heart.svg"
alt="иконка сердечка"
class="footer__image"
/>
<p class="js-team-modal team-modal">by GoIT Students</p>
</div>
</div>

</footer>
</div>
</footer>
110 changes: 110 additions & 0 deletions src/sass/components/_team-modal.scss
Original file line number Diff line number Diff line change
@@ -0,0 +1,110 @@
.basicLightbox {
overflow: scroll;
}

.team-wrapper {
display: flex;
flex-wrap: wrap;

margin: -20px;

@media screen and (max-width: ($tablet - 1)) {
margin-top: 70px;
}

width: 240px;

background-color: $white;
border-radius: 15px;

@media screen and (min-width: $tablet) {
width: 600px;

border-radius: 25px;
}

@media screen and (min-width: $desktop) {
margin: -30px;

width: 800px;
}
}

.team-card {
position: relative;

display: flex;
flex-direction: column;
align-items: center;

margin: 20px;

width: calc((100% - 80px) / 2);

@media screen and (min-width: $tablet) {
width: calc((100% - 160px) / 4);
}

@media screen and (min-width: $desktop) {
margin: 30px;

width: calc((100% - 240px) / 4);
}
}

.team-image {
margin-bottom: 10px;

width: 100%;

border-radius: 50%;
box-shadow: 5px 5px 11px -2px $dark;
}

.team-name {
margin-bottom: 5px;

font-family: $mainFont;
font-weight: 700;
}

.team-role {
font-family: $mainFont;

@media screen and (max-width: ($tablet - 1)) {
font-size: 14px;
}

color: $accentColor;
}

.team-git {
position: absolute;

top: 65px;
right: -10px;

@media screen and (min-width: $tablet) {
top: 100px;
}

@media screen and (min-width: $desktop) {
top: 120px;
}

transform: scale(1);
@include transition(transform);

&:hover,
&:focus {
transform: scale(1.5);
}
}

// footer

.team-modal {
text-decoration: underline;

cursor: pointer;
}
3 changes: 1 addition & 2 deletions src/sass/main.scss
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,4 @@
@import './components/pagination';
@import './components/modalFilmCard';
@import './components/backdrop';


@import './components/team-modal';