-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/alt metadata json repo #6
Feature/alt metadata json repo #6
Conversation
This looks great, thanks for your contribution! I just left for vacation so I won't be available for about a week, but once I'm back at my computer I'll do a deeper review/testing on the server. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot to submit the review, aside from that one change I think it should be good.
… fixes split path array eval
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good
Just pushed the updates to the server, your changes should be reflected |
Just tested having deep directories path and it works. Thanks for merging my PR, we're going to be using this action extensively. |
Awesome, glad to hear it! If you have any other suggestions at all of features/whatnot feel free to make an issue, I'd like to work on this a bit more in the future. |
Alternate repo for hosting json and fix to inputs.path
inputs.path
not properly working for nested paths. i.e.directory/subfile.json
.Attempts to fix... while I tested non server script work, I obviously have not tested it in your server. So please be mindful to test before publishing it.