Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/alt metadata json repo #6

Merged
merged 5 commits into from
Aug 4, 2021

Conversation

jcuna
Copy link

@jcuna jcuna commented Jul 22, 2021

Alternate repo for hosting json and fix to inputs.path

  • Allows for use of alternative repo to host shields.json. Useful for running an action in a private repo while pushing shields.json to a public repo where it can be properly referenced.
  • Attempts to fix inputs.path not properly working for nested paths. i.e. directory/subfile.json.
  • Updates readme with instructions on new options

Attempts to fix... while I tested non server script work, I obviously have not tested it in your server. So please be mindful to test before publishing it.

@RubbaBoy
Copy link
Owner

This looks great, thanks for your contribution! I just left for vacation so I won't be available for about a week, but once I'm back at my computer I'll do a deeper review/testing on the server.

Copy link
Owner

@RubbaBoy RubbaBoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to submit the review, aside from that one change I think it should be good.

Copy link
Owner

@RubbaBoy RubbaBoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good

@RubbaBoy RubbaBoy merged commit 876af1c into RubbaBoy:master Aug 4, 2021
@RubbaBoy
Copy link
Owner

RubbaBoy commented Aug 4, 2021

Just pushed the updates to the server, your changes should be reflected

@jcuna
Copy link
Author

jcuna commented Aug 5, 2021

Just tested having deep directories path and it works. Thanks for merging my PR, we're going to be using this action extensively.

@RubbaBoy
Copy link
Owner

RubbaBoy commented Aug 5, 2021

Awesome, glad to hear it! If you have any other suggestions at all of features/whatnot feel free to make an issue, I'd like to work on this a bit more in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants