Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CKEditor to Version 44.1.0 #4027

Open
chzauleck opened this issue Jan 8, 2025 · 2 comments · Fixed by #4083
Open

Update CKEditor to Version 44.1.0 #4027

chzauleck opened this issue Jan 8, 2025 · 2 comments · Fixed by #4083
Assignees
@chzauleck

Comments

@chzauleck
Copy link
Contributor

should improve table styling and loading times
@chzauleck chzauleck self-assigned this Jan 8, 2025
chzauleck added a commit that referenced this issue Jan 14, 2025
@chzauleck
Issue #4027: improved richtext styling
264553e 
- fixed unneccessary empty lines being added
- fixed table alignments
- set default alignment for table and image to block center
- stop ckeditor from filtering out harmless html tags
chzauleck added a commit that referenced this issue Jan 15, 2025
@chzauleck
Issue #4027: improved richtext styling
5beeec0 
- fixed unneccessary empty lines being added
- fixed table alignments
- set default alignment for table and image to block center
- stop ckeditor from filtering out harmless html tags
chzauleck added a commit that referenced this issue Jan 16, 2025
@chzauleck
Issue #4027: improved richtext styling
3cd3c40 
- fixed unneccessary empty lines being added
- fixed table alignments
- set default alignment for table and image to block center
- stop ckeditor from filtering out harmless html tags
chzauleck added a commit that referenced this issue Jan 16, 2025
@chzauleck
Issue #4027: improved ckeditor html tag configuration
afd5a11
svenoe pushed a commit that referenced this issue Jan 16, 2025
@chzauleck @svenoe
Issue #4027: improved richtext styling
959c55a 
- fixed unneccessary empty lines being added
- fixed table alignments
- set default alignment for table and image to block center
- stop ckeditor from filtering out harmless html tags
svenoe pushed a commit that referenced this issue Jan 16, 2025
@chzauleck @svenoe
Issue #4027: improved ckeditor html tag configuration
2f9039e
@chzauleck chzauleck linked a pull request Jan 16, 2025 that will close this issue
CKEditor version update #4083
Merged
@bschmalhofer
Copy link
Contributor

There are new Unittest failures. Could those be related to the CKEditor upgrade?

Test Summary Report
635216 -------------------
635217 /opt/otobo/scripts/test/Compile.t                                                                         (Wstat: 0 Tests: 1769 Failed: 0)
635218   TODO passed:   715, 845
635219 /opt/otobo/scripts/test/EmailParser/MultipartMixed.t                                                      (Wstat: 512 (exited 2) Tests: 15 Failed:        2)
635220   Failed tests:  14-15
635221   Non-zero exit status: 2
635222 /opt/otobo/scripts/test/Layout/RichTextDocumentComplete.t                                                 (Wstat: 1024 (exited 4) Tests: 4 Failed:        4)
635223   Failed tests:  1-4
635224   Non-zero exit status: 4

chzauleck added a commit that referenced this issue Jan 21, 2025
@chzauleck
Issue #4027: updated tests
ea27e47
chzauleck added a commit that referenced this issue Jan 21, 2025
@chzauleck
Issue #4027: improved tests
35336fb
@bschmalhofer
Copy link
Contributor

I suspect that

/opt/otobo/scripts/test/TemplateGenerator/AutoResponse.t                                                  (Wstat: 768 (exited 3) Tests: 31 Failed: 3)
  Failed tests:  11, 14, 17
  Non-zero exit status: 3

is also related to CKEditor.

chzauleck added a commit that referenced this issue Jan 27, 2025
@chzauleck
Issue #4027: updated tests
cdffb3d
chzauleck added a commit that referenced this issue Jan 27, 2025
@chzauleck
Issue #4027: improved tests
f0df3e4
chzauleck added a commit that referenced this issue Jan 27, 2025
@chzauleck
Issue #4027: fixed default alignment for images in richtext
fac420d 
images are now aligned left by default when inserted into the richtext editor
chzauleck added a commit that referenced this issue Jan 27, 2025
@chzauleck
Issue #4027: fixed some blockquotes not being removable
ce74662 
this was due to adding support for more html tags to improve styling in cited emails, this change was now undone in favour of better blockquote functionality
chzauleck added a commit that referenced this issue Jan 27, 2025
@chzauleck
Issue #4027: changed default line height in richtext
9b7301b
svenoe pushed a commit that referenced this issue Jan 27, 2025
@chzauleck @svenoe
Issue #4027: updated tests
21ed636
svenoe pushed a commit that referenced this issue Jan 27, 2025
@chzauleck @svenoe
Issue #4027: improved tests
1bad59b
svenoe pushed a commit that referenced this issue Jan 27, 2025
@chzauleck @svenoe
Issue #4027: fixed default alignment for images in richtext
273aefe 
images are now aligned left by default when inserted into the richtext editor
svenoe pushed a commit that referenced this issue Jan 27, 2025
@chzauleck @svenoe
Issue #4027: fixed some blockquotes not being removable
f9dcaea 
this was due to adding support for more html tags to improve styling in cited emails, this change was now undone in favour of better blockquote functionality
svenoe pushed a commit that referenced this issue Jan 27, 2025
@chzauleck @svenoe
Issue #4027: changed default line height in richtext
8b1c32c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chzauleck chzauleck

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CKEditor version update RotherOSS/otobo
2 participants
@bschmalhofer @chzauleck