Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for relevant changes before building devel images on Github #3654

Closed
bschmalhofer opened this issue Jul 30, 2024 · 3 comments
Closed

Check for relevant changes before building devel images on Github #3654

bschmalhofer opened this issue Jul 30, 2024 · 3 comments
Assignees
@bschmalhofer
Labels
docker Docker related issues Github Actions Related to Github Actions

Comments

@bschmalhofer
Copy link
Contributor

bschmalhofer commented Jul 30, 2024 •
edited
Loading

The devel images are still build for every change. In the cases where the build context is not . this is not really necessary. Check with https://github.com/marketplace/actions/changed-files checking whether the relevant files have changed

Originally posted by @bschmalhofer in #3628 (comment)
@bschmalhofer bschmalhofer self-assigned this Jul 30, 2024
@bschmalhofer bschmalhofer added this to the OTOBO 10.0 milestone Jul 30, 2024
@bschmalhofer bschmalhofer added the docker Docker related issues label Jul 30, 2024
bschmalhofer added a commit that referenced this issue Aug 1, 2024
@bschmalhofer
Issue #3654: build devel images only when necessary
ea02467
bschmalhofer added a commit that referenced this issue Aug 1, 2024
@bschmalhofer
Issue #3654: conditionally build devel images only, check against cur…
1f29c9c 
…rent branch
bschmalhofer added a commit that referenced this issue Aug 1, 2024
@bschmalhofer
Issue #3654: the hopefully correct key is 'base', not 'path'
b2a16ff
bschmalhofer added a commit that referenced this issue Aug 1, 2024
@bschmalhofer
Issue #3654: try to make complex condition work
6707533
@bschmalhofer
Copy link
Contributor Author

Looks like the solution using https://github.com/marketplace/actions/paths-changes-filter works. Let's keep this issue open for a while, to see wheter there are any problems.

stefanhaerter pushed a commit that referenced this issue Aug 1, 2024
@bschmalhofer @stefanhaerter
Issue #3654: build devel images only when necessary
750c878
stefanhaerter pushed a commit that referenced this issue Aug 1, 2024
@bschmalhofer @stefanhaerter
Issue #3654: conditionally build devel images only, check against cur…
d7c3965 
…rent branch
stefanhaerter pushed a commit that referenced this issue Aug 1, 2024
@bschmalhofer @stefanhaerter
Issue #3654: the hopefully correct key is 'base', not 'path'
49cb0ff
stefanhaerter pushed a commit that referenced this issue Aug 1, 2024
@bschmalhofer @stefanhaerter
Issue #3654: try to make complex condition work
8319b0b
@bschmalhofer
Copy link
Contributor Author

The check seems to work. See https://github.com/RotherOSS/otobo/actions/runs/10212481636/job/28256036506 . Closing this issue.

@bschmalhofer bschmalhofer added the Github Actions Related to Github Actions label Aug 7, 2024
@bschmalhofer bschmalhofer removed this from the OTOBO 10.0 milestone Aug 9, 2024
@bschmalhofer
Copy link
Contributor Author

Removed the milestone as this was an infrastructure task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschmalhofer bschmalhofer

Labels
docker Docker related issues Github Actions Related to Github Actions
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bschmalhofer