-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use fixed versions of CPAN distributions for rebuilding Docker images #3617
Comments
The inital approach is that local build update cpanfile,snapshot and that the automated builds use it. TODO:
|
that file will be updated with local builds.
Currently the distinction is based on whether $DOCKER_TAG starts with 'local-'. Use the nifty heredoc syntac for complex bash commands
that file will be updated with local builds.
Currently the distinction is based on whether $DOCKER_TAG starts with 'local-'. Use the nifty heredoc syntac for complex bash commands
Buildkit seems to be used by default in the automated builds on Docker Hub. Specify the fronted version 1.4 because this version entails heredoc support.
not brave enough to go to docker/dockerfile:1 which would get the latest minor version
The automated builds initially did not accept the heredoc syntax in the Dockerfile otobo.web.dockerfile . Declaring the Dockerfile frontend in the Dockerfile did the trick.
|
There still is a problem. When changes from one branch are merged the next higher version branch, e.b. rel-10_1 merged into rel-11_0, then cpanfile.docker.snapshot would also be merged. Excluding files from |
rather move cpanfile.snapshot and hope that App::cpm does the right thing
mainly to make the args parameter non-empty and cpm actually does install
rather move cpanfile.snapshot and hope that App::cpm does the right thing
mainly to make the args parameter non-empty and cpm actually does install
the redundant action also had an error
the redundant action also had an error
the redundant action also had an error
No idea why IO::Socket::SSL is now 2.085 instead of 2.087
for compile tests and for the CodePolicy Rebuild the local lib cache only when cpanfile.docker has changed
for compile tests and for the CodePolicy Rebuild the local lib cache only when cpanfile.docker has changed
I inspected the Github action https://github.com/RotherOSS/otobo/blob/rel-11_0/.github/workflows/cache_local_lib.yml . The action does not consider cpanfile.docker.snapshot when populating the cache. But this is fine. The cache is only used for CodePolicy checks, it does not matter whether the fixed or the most current CPAN module versions are used. |
Another problem are |
Well, that did not work out. The next idea is actually a somewhat secret option. |
This has the advantage that the required Perl modules for carton are not included in the final Docker image. The workarounds for generating the fatpack are described in otobo.web.dockerfile.
This has the advantage that the required Perl modules for carton are not included in the final Docker image. The workarounds for generating the fatpack are described in otobo.web.dockerfile.
Switched to fatpacked carton script. The unitest show no new failures, just the 10 already known failures. Looks good. See perl-carton/carton#237 and miyagawa/cpanminus#577 for the needed workaround for |
Originally posted by @bschmalhofer in #3448 (comment)
The text was updated successfully, but these errors were encountered: