SMW 2.1 -> 2.5.8

[hcooper]

---

Stack created with Sapling. Best reviewed with ReviewStack.

• PHP 5.6 -> 7.1 #105
• MW 1.24.1 -> 1.27.7 #104
• -> SMW 2.1 -> 2.5.8 #55
• webserver ubuntu:20.04 -> 24.04 #103

[BenjaminPelletier]

Just to give a review update, I am definitely still planning on approving -- the thing I want to do before that is independently verify deployment on my GCP dev instance. Thanks for this work!

[hcooper]

Argh. Just found this breaks SemanticForms (the "Edit" tab reverts back to the dumb editor, but the extension is still listed in Special:Version).

Bisecting it, even just upgrading SMW one version, to 2.2.0, breaks it.

[hcooper]

After waaaay too much debugging at a low level (upgrading, downgrading, printing, dumping, etc), I went back a re-read the docs.

https://www.mediawiki.org/wiki/Extension:Page_Forms/The_%22edit_with_form%22_tab

A (the?) fix is just to add a line to each Category page (Canyon, Region, etc) defining the default form template. For example:

Here: http://ropewiki2.ak/Category:Regions/edit add the line {{#default_form:Region}}

After that, the expected "Edit/Edit source" tabs reappear.

It's not clear what's changed in the upgrade (it's definitely tied to moving to above SMW 2.1), but I like this as a fix.

Update: This explains it:

The syntax "[[Has default form::form-name]]", that was used in former versions of this extension, i.e. when it was called Semantic Forms, to bind a form to a page, no longer works; every such call has to be changed to #default_form.

As an aside, I don't think we need to keep our own copy of the old SemanticForms repo ourselves. Cloning the PageForms repo and checking out branch 3.7 (the last version of SemanticForms) seems to work fine.

[hcooper]

I'm testing the default form conversion on some lesser used categories to check they can be switched before the upgrade. e.g. https://ropewiki.com/Category:Knots

Update: this is complete for all category pages which had a default form defined.

[BenjaminPelletier]

Looks like you have good testing for the change (thanks for that work!), so let's update :)