Skip to content

Commit

Permalink
Remove unnecessary type generation.
Browse files Browse the repository at this point in the history
  • Loading branch information
RohanPadmanabhan committed Aug 9, 2018
1 parent dd1619f commit 842e181
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions packages/perspective/src/js/perspective.js
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,9 @@ function infer_type(x) {
function parse_data(data, names, types) {
let preloaded = types ? true : false;
names = names || [];
if (types === undefined) {

const isColumnOriented = Array.isArray(data[Object.keys(data)[0]]);
if (types === undefined || isColumnOriented) {
types = []
} else {
let _types = [];
Expand Down Expand Up @@ -193,7 +195,7 @@ function parse_data(data, names, types) {
row_count = col.length;
}

} else if (Array.isArray(data[Object.keys(data)[0]])) {
} else if (isColumnOriented) {

// Names and types will be added (all columns must be given set)
names = [];
Expand Down

0 comments on commit 842e181

Please sign in to comment.