-
Notifications
You must be signed in to change notification settings - Fork 11.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEW] Adds settings to limit chain of quotes #7273
Conversation
Should we actually add a migration? It will require looking through every message right? won't this be pretty time consuming to look through every message and walk through its attachments? |
@geekgonecrazy we search for every message with N levels of attachments, so yes, it should be quite time consuming for instances with lots of messages. The objective of the migration would be to fix older messages that are already breaking the server, but this could be accomplished simply by providing a script which could be run to fix those messages by those who need it. |
I did some refactoring and now the solutions uses a recursive function to go through all attachments in the message (previously it was fixing only the first one). |
Excuse me but how to active it definitively on my rocket instance ? Could you explain step by step how to upgrade this in code @gdelavald ? I'm using docker install |
@RocketChat/core
Closes #7192
Adds a setting to limit the number of chained quoted messages

The default limit is set to 2 but can be configured under Settings > Messages

Also created a migration step to update past messages with excessive number of quotes, will update the PR to add it after @sampaiodiego's tests.