Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Avatar images on old Livechat client #14590

Merged
merged 8 commits into from
May 25, 2019
Merged

[FIX] Avatar images on old Livechat client #14590

merged 8 commits into from
May 25, 2019

Conversation

arminfelder
Copy link
Contributor

@arminfelder arminfelder commented May 22, 2019 •
edited
Loading

changes avatar url from /avatar/${ username }.jpg to avatar/${ username } , to show user uploaded avatar image in livechat

Closes #14591

sampaiodiego
sampaiodiego approved these changes May 25, 2019
View reviewed changes
Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good finding.. Thank you for the fix. 👍

@sampaiodiego sampaiodiego changed the title [FIX] Livechat avatar fix [FIX] Avatar images on old Livechat client May 25, 2019
@sampaiodiego sampaiodiego merged commit 5a6ee5e into RocketChat:develop May 25, 2019
wreiske added a commit to wreiske/Rocket.Chat that referenced this pull request May 27, 2019
@wreiske
Merge branch 'new-reports-ui' of https://github.com/wreiske/Rocket.Chat…
a120595 
… into new-reports-ui

* 'new-reports-ui' of https://github.com/wreiske/Rocket.Chat: (97 commits)
  LingoHub Update 🚀 (RocketChat#14643)
  [FIX] Role name spacing on Permissions page (RocketChat#14625)
  [FIX] Avatar images on old Livechat client (RocketChat#14590)
  [FIX] Inject code at the end of <head> tag (RocketChat#14623)
  [FIX] Mailer breaking if user doesn't have an email address (RocketChat#14614)
  Ci improvements (RocketChat#14600)
  [FIX] E2E messages not decrypting in message threads (RocketChat#14580)
  Fix: emoji render performance for alias (RocketChat#14593)
  [FIX] Send replyTo for livechat offline messages (RocketChat#14568)
  Federation i18n message changes (RocketChat#14595)
  [REGRESSION] Fix Slack bridge channel owner on channel creation (RocketChat#14565)
  Fix thumbs up emoji shortname (RocketChat#14581)
  Fix broken logo url in app.json (RocketChat#14572)
  Add digitalocean button to readme (RocketChat#14583)
  Fix: Add emoji shortnames to emoji's list (RocketChat#14576)
  [IMPROVE] Message rendering time (RocketChat#14252)
  [IMPROVE] Change user presence events to Meteor Streams (RocketChat#14488)
  Removed unnecessary DDP unblocks (RocketChat#13641)
  [FIX] Downloading files when running in sub directory (RocketChat#14485)
  [FIX] Broken layout when sidebar is open on IE/Edge (RocketChat#14567)
  ...
@sampaiodiego sampaiodiego mentioned this pull request May 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampaiodiego sampaiodiego sampaiodiego approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Livechat shows wrong avatar
2 participants
@arminfelder @sampaiodiego