Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVEMENT] Don't group messages with different alias #14257

Merged
merged 3 commits into from
May 15, 2019
Merged

[IMPROVEMENT] Don't group messages with different alias #14257

merged 3 commits into from
May 15, 2019

Conversation

jungeonkim
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Apr 26, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@jungeonkim jungeonkim force-pushed the fix.messagegrouping branch from 3b00647 to f633b1b Compare April 28, 2019 05:23
@tassoevan tassoevan added this to the 1.0.2 milestone Apr 29, 2019
@rodrigok
Copy link
Member

For me this is not a FIX but a IMPROVEMENT, so I'd say it should be released on 1.1.0

@rodrigok rodrigok modified the milestones: 1.0.2, 1.1.0 Apr 29, 2019
@ggazzo ggazzo changed the title [FIX] Don't group message with different alias [IMPROVE] Don't group message with different alias Apr 30, 2019
@ggazzo ggazzo changed the title [IMPROVE] Don't group message with different alias [IMPROVEMENT] Don't group message with different alias Apr 30, 2019
@ggazzo ggazzo changed the title [IMPROVEMENT] Don't group message with different alias [IMPROVEMENT] Don't group messages with different alias May 15, 2019
@ggazzo ggazzo merged commit de20960 into RocketChat:develop May 15, 2019
@sampaiodiego sampaiodiego mentioned this pull request May 28, 2019
Merged
@rodrigok rodrigok mentioned this pull request Nov 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tassoevan tassoevan tassoevan approved these changes

Assignees
No one assigned
Labels
type: improvement ui/ux
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@jungeonkim @CLAassistant @rodrigok @tassoevan @ggazzo