Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Showing the id instead of the name of custom notification sound #13660

Merged
merged 3 commits into from
May 16, 2019

Conversation

knrt10
Copy link
Contributor

@knrt10 knrt10 commented Mar 10, 2019

Closes #12685

Now custom sound names are rendered correctly.

2019-03-10 07 32 50

cc @tassoevan would you please review.

@engelgabriel engelgabriel requested a review from ggazzo March 18, 2019 12:36
@engelgabriel engelgabriel added this to the 1.0.0 milestone Mar 18, 2019
@engelgabriel engelgabriel modified the milestones: 1.0.0, 1.1.0 Apr 6, 2019
@rodrigok rodrigok changed the title [Fix] Fix custom notification sound names [FIX] Showing the id instead of the name of custom notification sound May 15, 2019
@ggazzo ggazzo merged commit 82aceab into RocketChat:develop May 16, 2019
@sampaiodiego sampaiodiego mentioned this pull request May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Individual chat notification sound bug
4 participants