Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Multiple Slack Importer Bugs #12084

Merged
merged 9 commits into from
May 19, 2019
Merged

[FIX] Multiple Slack Importer Bugs #12084

merged 9 commits into from
May 19, 2019

Conversation

Hudell
Copy link
Contributor

@Hudell Hudell commented Sep 17, 2018 •
edited
Loading

  1. Improved Importer Code Readability
  2. Added Data Validation, to avoid issues with a missing message's user when the admin chose not to import all users.
  3. Fixed errors when importing files from slack on the new structure.

@Hudell Hudell requested a review from rodrigok September 17, 2018 15:50
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-12084 September 17, 2018 15:51 Inactive
@Hudell Hudell added this to the 0.70.0 milestone Sep 17, 2018
@Hudell Hudell modified the milestones: 0.70.0, 0.71.0 Oct 9, 2018
@Hudell Hudell requested a review from sampaiodiego October 9, 2018 19:10
sampaiodiego
sampaiodiego previously requested changes Oct 18, 2018
View reviewed changes
Copy link
Member

@sampaiodiego sampaiodiego left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this diff was hard to read 😅

@rodrigok
Copy link
Member

@Hudell can you improve the title? Imagine you are an user reading the change log 😄

@rodrigok rodrigok modified the milestones: 0.71.0, 0.72.0 Nov 1, 2018
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-12084 December 3, 2018 16:54 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-12084 December 3, 2018 17:04 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-12084 December 3, 2018 19:59 Inactive
@Hudell Hudell changed the title [FIX] Reduced code complexity and added data validation [FIX] Multiple Slack Importer Bugs Dec 3, 2018
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-12084 December 3, 2018 20:14 Inactive
@theorenck theorenck removed this from the 0.72.0 milestone Dec 12, 2018
@theorenck theorenck added this to the Short-term milestone Dec 12, 2018
@rodrigok rodrigok modified the milestones: Short-term, 1.1.0 May 19, 2019
@rodrigok rodrigok merged commit 6188480 into develop May 19, 2019
@rodrigok rodrigok deleted the fix.slack-importer branch May 19, 2019 14:48
@sampaiodiego sampaiodiego mentioned this pull request May 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcosSpessatto MarcosSpessatto MarcosSpessatto approved these changes

@sampaiodiego sampaiodiego sampaiodiego left review comments

@rodrigok rodrigok Awaiting requested review from rodrigok

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
7 participants
@Hudell @rodrigok @sampaiodiego @MarcosSpessatto @engelgabriel @theorenck @pierre-lehnen-rc