-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Fix and improve Atlassian Crowd User Sync #11483
Conversation
could you get rid of this plain password saved in user document? |
Maybe it is good idea to merge these changes with https://gist.github.com/jsternadel/09d2a068343f64146e98f675b20666e7 together? |
Nice to see, that it progresses @engelgabriel |
It seems like a good part of this pull request is already implemented on our |
@Hudell can you check what is different from our new changes and see if it makes sense? |
@Hudell ping, can you check this? |
I compared the PR with the existing implementation and with the only exception of a try catch being handled in a different place, it's pretty much the same code. I'll be closing this one now. |
Before the sync was running into a exception of "Cannot read property 'crowdClient' of undefined" and was running on all instances redundant.
Now the described issue was fixed and used SyncedCron with configurable sync interval.