Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Fix and improve Atlassian Crowd User Sync #11483

Closed
wants to merge 8 commits into from

Conversation

kos4live
Copy link
Contributor

Before the sync was running into a exception of "Cannot read property 'crowdClient' of undefined" and was running on all instances redundant.
Now the described issue was fixed and used SyncedCron with configurable sync interval.

@RocketChat RocketChat deleted a comment Jul 18, 2018
@RocketChat RocketChat deleted a comment Jul 18, 2018
@RocketChat RocketChat deleted a comment Jul 18, 2018
@RocketChat RocketChat deleted a comment Jul 18, 2018
@RocketChat RocketChat deleted a comment Jul 18, 2018
@RocketChat RocketChat deleted a comment Jul 18, 2018
@piotrkochan
Copy link
Contributor

could you get rid of this plain password saved in user document?

@piotrkochan
Copy link
Contributor

Maybe it is good idea to merge these changes with https://gist.github.com/jsternadel/09d2a068343f64146e98f675b20666e7 together?

@steerben
Copy link
Contributor

Nice to see, that it progresses @engelgabriel

@Hudell
Copy link
Contributor

Hudell commented Feb 18, 2019

It seems like a good part of this pull request is already implemented on our develop branch now. @kos4live I'm sorry it took us so long to check this, but do you mind comparing your changes to the ones that were merged and check if there's anything missing?

@engelgabriel engelgabriel modified the milestones: 0.74.0, 1.0.0 Feb 22, 2019
@rodrigok
Copy link
Member

rodrigok commented Mar 2, 2019

@Hudell can you check what is different from our new changes and see if it makes sense?

@engelgabriel engelgabriel modified the milestones: 1.0.0, 1.1.0 Apr 29, 2019
@rodrigok
Copy link
Member

@Hudell ping, can you check this?

@rodrigok rodrigok modified the milestones: 1.1.0, 1.2.0 May 15, 2019
@Hudell
Copy link
Contributor

Hudell commented May 15, 2019

I compared the PR with the existing implementation and with the only exception of a try catch being handled in a different place, it's pretty much the same code.

I'll be closing this one now.

@Hudell Hudell closed this May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants