Merge pull request #944 from ndarilek/master

Accessibility fixes
RocketChat · Oct 1, 2015 · bedddfa · bedddfa
2 parents 08eee0f + 8680493
commit bedddfa
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 8 deletions.
diff --git a/client/views/app/flexTabBar.html b/client/views/app/flexTabBar.html
@@ -1,14 +1,14 @@
 <template name="flexTabBar">
 	{{#each buttons}}
 		<div class="tab-button {{active}}" data-template="{{template}}" title="{{title}}">
-			<i class="{{icon}}"></i>
+			<i class="{{icon}}" aria-label="{{title}}"></i>
 		</div>
 	{{/each}}
 	{{!-- <div class="tab-button" data-target="messageSearch" title="Search">
-		<i class="icon-search"></i>
+		<i class="icon-search" aria-label="{{_ "Search"}}"></i>
 	</div>
 	<div class="tab-button" data-target="membersList" title="Member List">
-		<i class="icon-users"></i>
+		<i class="icon-users" aria-label="{{_ "Members_List"}}"></i>
 	</div> --}}
 	{{!-- <div class="tab-button" data-target="pinned-messages" title="Pinned Messages">
 		<i class="icon-pin"></i>

diff --git a/client/views/app/room.html b/client/views/app/room.html
@@ -16,7 +16,7 @@ <h2>
 					<span class="room-title {{editingTitle}}">{{roomName}}</span>
 					{{#if canEditName}}
 					<input type="text" id="room-title-field" class="{{showEditingTitle}}" value="{{roomNameEdit}}" dir="auto">
-					<a href="#edit" class="edit-room-title"><i class="icon-pencil"></i></a>
+					<a href="#edit" class="edit-room-title"><i class="icon-pencil" aria-label="{{_ "Edit"}}"></i></a>
 					{{/if}}
 				</h2>
 			</header>
@@ -51,7 +51,7 @@ <h2>
 			<div class="messages-box">
 				<div class="ticks-bar"></div>
 				<div class="wrapper">
-					<ul>
+					<ul aria-live="polite">
 						{{#if hasMore}}
 							<li class="load-more">
 								{{#if isLoading}}
@@ -86,14 +86,14 @@ <h2>
 							<div class="input-message-container">
 								{{> messagePopupConfig getPupupConfig}}
 								<textarea dir="auto" name="msg" maxlength="{{maxMessageLength}}" class="input-message autogrow-short" placeholder="{{_ 'Message'}}"></textarea>
-								<i class="icon-paper-plane" title="{{_ "Send_Message"}}"></i>
+								<i class="icon-paper-plane" title="{{_ "Send_Message"}}" aria-label="{{_ "Send_Message"}}"></i>
 							</div>
 							{{#if canRecordAudio}}
 								<div class="mic">
-									<i class="icon-mic"></i>
+									<i class="icon-mic" aria-label="{{_ "Record"}}"></i>
 								</div>
 								<div class="stop-mic hidden">
-									<i class="icon-stop"></i>
+									<i class="icon-stop" aria-label="{{_ "Stop_Recording"}}"></i>
 								</div>
 							{{/if}}
 						</div>

diff --git a/i18n/en.i18n.json b/i18n/en.i18n.json
@@ -246,6 +246,7 @@
   "Quick_Search" : "Quick Search",
   "quote" : "quote",
   "Recents" : "Recents",
+  "Record" : "Record",
   "Register" : "Register a new account",
   "Registration_Succeeded" : "Registration Succeeded",
   "Remember_me" : "Remember me",
@@ -319,6 +320,7 @@
   "Stats_Total_Private_Groups" : "Total Private Groups",
   "Stats_Total_Rooms" : "Total Rooms",
   "Stats_Total_Users" : "Total Users",
+  "Stop_Recording" : "Stop Recording",
   "strike" : "strike",
   "Submit" : "Submit",
   "S_new_messages_since_s" : "%s new messages since %s",