Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General Settings are not scrollable in Desktop App (on Windows 10) #2530

Closed
2 of 5 tasks
vkuhnde opened this issue Oct 21, 2022 · 3 comments · Fixed by #2568
Closed
2 of 5 tasks

General Settings are not scrollable in Desktop App (on Windows 10) #2530

vkuhnde opened this issue Oct 21, 2022 · 3 comments · Fixed by #2568

Comments

@vkuhnde
Copy link

vkuhnde commented Oct 21, 2022

Search before asking

  • I had searched in the issues and found no similar issues.

Operating System

  • macOS
  • Windows
  • Linux

Operating System Version

Windows 10 Pro 21H2

It happens on the web browser too?

No, it just happens on the Desktop app

Rocket.Chat Desktop App Version

3.8.12

Rocket.Chat Server Version

5.1

Describe the bug

The General Settings tab does not show all options on small screens. It is not possible to scroll down or otherwise move more options into the viewport.

This does not apply to Rocket.Chat in web browsers, because the web version does not have these settings.

How to Reproduce

  1. Open Settings (gear icon on the bottom left)
  2. Can't scroll --> can't see all options of the "General" tab on small screens

Describe your Expected behavior

I would like to see all settings even on small screens. The probably easiest solution is to make the settings scrollable.

Anything else

No response

Are you willing to submit a code contribution?

  • Yes, I am willing to submit a Pull Request!
@thepranays
Copy link
Contributor

I would like to work on this issue as this seems a beginner friendly one.Can i ?

@jeanfbrito
Copy link
Collaborator

Hello @thepranays, you don't need to ask permission. Just make it and open a PR. I will review it as soon as possible.

@thepranays
Copy link
Contributor

@jeanfbrito Hey,Can you please review my PR on this issue.

jeanfbrito added a commit that referenced this issue Dec 31, 2022
)

* SettingsView Added Auto-Scrolling By adding Overflow-Y:auto

* lint fix

Co-authored-by: Jean Brito <jeanfbrito@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants