feat: add event organizer logo form field and update event page #58
Conversation
|
|
| <Form.Control | ||
| name="logo-url" | ||
| type="url" | ||
| placeholder="" |
There was a problem hiding this comment.
Please add a placeholder with some link value. It will help the user know the correct format of data to be added to the form.
Thank you!
There was a problem hiding this comment.
Done! Please review the changes.
Thank You!
| <Image src={event.data.attributes["logo-url"]} width={100} /> | ||
| </div> | ||
| <center><h6> Organizer </h6></center> |
There was a problem hiding this comment.
While you are here. Can you try to make the logo resize responsively?
34c9c6c to
1626248
Compare
| @@ -59,6 +59,7 @@ export const EventShow = ({ event, error, speaker, prsession }) => { | |||
| <div className={styles.event_logo}> | |||
| <Image src={event.data.attributes["logo-url"]} width={100} /> | |||
| </div> | |||
| <center><h6> Organizer </h6></center> | |||
There was a problem hiding this comment.
@r3yc0n1c please use div with style text-align=center in place of center, please avoid using center since it is already depreciated.
Thank you!
There was a problem hiding this comment.
done! let me know if I need to change something.
Thanks!
1626248 to
1fd0265
Compare
| @@ -59,6 +59,7 @@ export const EventShow = ({ event, error, speaker, prsession }) => { | |||
| <div className={styles.event_logo}> | |||
| <Image src={event.data.attributes["logo-url"]} width={100} /> | |||
| </div> | |||
| <div style={{textAlign: 'center'}}><h6> Organizer </h6></div> | |||
There was a problem hiding this comment.
@r3yc0n1c Please use className for styling since if we use inline styling, the customization of the components' style will be affected.
Because for any style changes needed, the user would have to do modifications in the component (EventBasicDetail.js) in case of inline styling; However, for separate className in a .css file, they can modify a single CSS class property in the style.css which is pretty convenient.
Thank you!
There was a problem hiding this comment.
got it! please check the changes now...
Thank you!
1fd0265 to
a65c976
Compare
…form-field feat: add event organizer logo form field and update event page
resolves #52
Summary:
Event Organizer logo(namedlogo-url) inside the EventBasicCreate componentScreenshots: