Revert delete runner changes #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6b7d840 to
272a7af
Compare
272a7af to
07b4a72
Compare
gl-rockx
approved these changes
Nov 18, 2022
gl-rockx
added a commit
that referenced
this pull request
Nov 29, 2022
* add implementation for blame type FailedEcies (#16) * add implementation for blame type FailedEcies * add spec test for blame type FailedEcies * add implementation for blame type InvalidScaler * add spec test for blame type invalid scaler * add implementation for invalid commitment blame * add spec test for blame type InvalidCommitment * fix lint issues * remove redundant code from blame spec test * fix generate json for frost spec tests * Fix typo * Fix blame * Refactor blame * BlameMessage has to contain SignedMessage * Refactor blame * Linting * Improve readability * Fix unhandled error Co-authored-by: gldeng <realgldeng@gmail.com> * Revert delete runner changes (#15) * revert delete runner changes * fix blame (type InvalidMessage) spec test * Re-generate spectest Co-authored-by: Aayush Gautam <110584034+aayush-rockx@users.noreply.github.com> Co-authored-by: gldeng <realgldeng@gmail.com>
aayush-rockx
pushed a commit
that referenced
this pull request
Nov 27, 2023
* implementation * tmp * remove unused * use latest go-eth2-client version * use latest go-eth2-client version * return block data as versioned & hashroot * improve log * upgrade go-eth2-client v0.15.8 * proposerCalls interface change * versioned block spec tests * generate test json * include all versioned block spec tests * remove unused fields * use block version instead of hardcoded * keep only bellatrix block version * mention github issue * SSV comparable state ssvlabs#215 * use proper package names * Create beacon_node_versioned.go * Create ssv_msgs_versioned.go * versioned state comparison example * TestProposerWithJustificationsConsensusData versioned example * versioned TestingProposerDutyNextEpoch example * versioned PostConsensusWrongProposerMsg example * versioned PostConsensusWrongSigProposerMsg example * versioned PostConsensusProposerTooManyRootsMsg example * versioned PostConsensusSigProposerWrongBeaconSignerMsg example * return testing blocks as versioned * use TestingProposerDuty versioned slot * add versioned PostConsensusProposerTooFewRootsMsg * versioned PostConsensusProposerTooFewRootsMsg example * versioned runner decided msgs * randao versioned * versioned PreConsensusRandaoMsg SSVDecidingMsgs example * versioned PreConsensusRandaoNextEpochMsg example * versioned PreConsensusRandaoDifferentEpochMsg example * versioned PreConsensusRandaoTooManyRootsMsg example * versioned PreConsensusRandaoTooFewRootsMsg example * versioned PreConsensusRandaoWrongBeaconSigMsg example * versioned PreConsensusRandaoDifferentSignerMsg example * go fmt ./... * use versioned PreConsensusRandaoMsg * use versioned TestingProposerDuty * delete redundant tests (#1) * remove (versioned) name * remove unused * versioned GetBeaconBlock/GetBlindedBeaconBlock * fix merge conflict * use TestingDutySlotBellatrixNextEpoch * add versioned TestingInvalidDutySlot * versioned TestingInvalidDutySlot example * versioned TestingInvalidDutySlot example2 * add an issue comment * versioned messages tests * versioned runner consensus * versioned runner/duties/newduty * versioned runner/duties/proposer * versioned runner/full_happy_flow * versioned runner/postconsensus * versioned runner/pre_consensus_justifications * versioned runner/preconsensus * versioned valcheck/valcheckduty * versioned consensusdata/proposer * versioned beacon_node_test * remove non-versioned funcs * ssz withdrawals * capella support * versioned SSZWithdrawalsMarshaling * introduce versioned epoch + use goerli capella epoch fork * remove versioned block IsEmpty func * review adjustments * beacon_node_consts * multi version FullHappyFlow example * ExpectedDecidingMsgsForHeightWithRoot * ExpectedSSVDecidingMsgsV * use ExpectedSSVDecidingMsgsV * adjust multi version FullHappyFlow example * future_decided sc test * post_decided sc test * post_finish sc test * valid_decided sc test * valid_decided_7_operators sc test * comparable StartNewRunnerDutySpecTest * decided sc test * not_decided sc test * duplicate_msg sc test * duplicate_msg_different_roots sc test * inconsistent_beacon_signer sc test * post_quorum sc test * pre_decided sc test * quorum sc test * quorum_7_operators sc test * unknown_signer sc test * preconsensus/duplicate_msg sc test * preconsensus/no_running_duty sc test * preconsensus/post_decided_sc sc test * preconsensus/post_finish sc test * preconsensus/post_quorum sc test * preconsensus/quorum sc test * preconsensus/quorum_7_operators sc test * preconsensus/unknown_signer sc test * multi version TestBeaconBlockRoot * fix deadlock * add required fields to pass json tests * fix test comment * fix test * postconsensus/duplicate_msg sc full test * postconsensus/duplicate_msg_different_roots full sc test * postconsensus/inconsistent_beacon_signer full sc test * postconsensus/post_quorum full sc test * postconsensus/pre_decided full sc test * postconsensus/quorum full sc test * postconsensus/quorum_7_operators full sc test * postconsensus/unknown_signer full sc test * fix comment (#8) * root -> runner (#10) * add comments (#15) --------- Co-authored-by: Gal Rogozinski <galrogogit@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is to revert the previous change where when the node deletes the runner, it was only marked as deleted. This change will revert it and the runner will be deleted when the protocol finishes