Feature/rework dockerfile feedback

.dockerignore

@@ -1,17 +1,18 @@
-.vs
-.vscode
-bin
-[_][Bb]uild
-Builds/*
-Testing/*
-.idea
-cmake-build-debug
-cmake-build-release
-build
-external/*
-!external/CMakeLists.txt
+# Ignore everything by default
+*
 
-README.md
-CHANGELOG.md
-CONTRIBUTING.md
-LICENSE
+# First-order allow exception for select directories
+!/.clang-format
+!/.githooks
+!/CMakeLists.txt
+!/Dockerfile
+!/docs
+!/extensions
+!/extensions.repos
+!external/CMakeLists.txt
+!/include
+!/ros2_standalone
+!/setup.py
+!/src
+!/test
+!/tools

.github/dependabot.yml

@@ -0,0 +1,14 @@
+version: 2
+updates:
+  - package-ecosystem: "docker"
+    directory: "/"
+    schedule:
+      interval: "daily"
+    commit-message:
+      prefix: "🐳 "
+  - package-ecosystem: "github-actions"
+    directory: "/"
+    schedule:
+      interval: "daily"
+    commit-message:
+      prefix: "🛠️ "

Dockerfile

@@ -1,21 +1,59 @@
-ARG BASE_IMAGE=nvidia/cuda:11.7.1-devel-ubuntu22.04
+ARG BASE_IMAGE=base
+# Stage from full image tag name for dependabot detection
+FROM nvidia/cuda:11.7.1-devel-ubuntu22.04 as base
+
+################################################################################
+# MARK: prepper - prep rgl dependencies
+################################################################################
+FROM $BASE_IMAGE as prepper
 ARG DEBIAN_FRONTEND=noninteractive
 
-FROM ${BASE_IMAGE} as rgl-core
-RUN apt update
-RUN apt install -y \
-    git \
-    cmake \
-    python3
+# Edit apt config for caching and update once
+RUN mv /etc/apt/apt.conf.d/docker-clean /etc/apt/ && \
+    echo 'Binary::apt::APT::Keep-Downloaded-Packages "true";' \
+      > /etc/apt/apt.conf.d/keep-cache && \
+    apt-get update
+
+# Install bootstrap tools for install scripts
+RUN --mount=type=cache,sharing=locked,target=/var/cache/apt \
+    apt-get install -y --no-install-recommends \
+        cmake \
+        git \
+        python3 \
+        sudo
+
+# Set working directory using standard opt path
+WORKDIR /opt/rgl
+
+# Copy only dependencies definition files
+COPY ./setup.py .
 
-FROM rgl-core AS build
+# install dependencies while caching apt downloads
+# RUN --mount=type=cache,sharing=locked,target=/var/cache/apt \
+#    ./setup.py --install-deps-only
+
+################################################################################
+# MARK: builder - build rgl binaries
+################################################################################
+FROM prepper AS builder
 ARG OptiX_INSTALL_DIR=/optix
 
-WORKDIR /code
-COPY . .
+# Disable DNS lookups
+RUN cat /etc/nsswitch.conf && \
+    sed -e 's#hosts:\(.*\)dns\(.*\)#hosts:\1\2#g' -i.bak /etc/nsswitch.conf && \
+    cat /etc/nsswitch.conf
 
+# Copy rest of source tree
+COPY . .
 RUN --mount=type=bind,from=optix,target=${OptiX_INSTALL_DIR} \
     ./setup.py
 
-FROM scratch AS export-binaries
-COPY --from=build /code/build/libRobotecGPULidar.so /
+# Restore DNS lookups
+RUN mv /etc/nsswitch.conf.bak /etc/nsswitch.conf && \
+    cat /etc/nsswitch.conf
+
+################################################################################
+# MARK: exporter - export rgl binaries
+################################################################################
+FROM scratch AS exporter
+COPY --from=builder /code/build/libRobotecGPULidar.so /

setup.py

@@ -240,8 +240,7 @@ def install_pcl_deps(cfg):
     if not os.path.isdir(cfg.VCPKG_DIR):
         if on_linux() and not inside_docker():  # Inside docker already installed
             print("Installing dependencies for vcpkg...")
-            run_system_command("sudo apt update")
-            run_system_command("sudo apt install git curl zip unzip tar freeglut3-dev libglew-dev libglfw3-dev")
+            run_system_command("sudo apt-get install -y git curl zip unzip tar freeglut3-dev libglew-dev libglfw3-dev")
         run_subprocess_command(
             f"git clone -b {cfg.VCPKG_TAG} --single-branch --depth 1 https://github.com/microsoft/vcpkg {cfg.VCPKG_DIR}")
     # Bootstrap vcpkg
@@ -265,8 +264,7 @@ def install_ros2_deps(cfg):
         if on_windows():
             run_system_command("pip install colcon-common-extensions")
         elif not inside_docker():  # Linux; Inside docker already installed
-            run_system_command("sudo apt update")
-            run_system_command("sudo apt install python3-colcon-common-extensions")
+            run_system_command("sudo apt-get install -y python3-colcon-common-extensions")
     # Clone radar msgs
     if not os.path.isdir(cfg.RADAR_MSGS_DIR):
         run_subprocess_command(
@@ -286,7 +284,7 @@ def ensure_git_lfs_installed():
         print("Installing git-lfs...")
         run_subprocess_command(
             "curl -s https://packagecloud.io/install/repositories/github/git-lfs/script.deb.sh | sudo bash")
-        run_subprocess_command("sudo apt install git-lfs")
+        run_subprocess_command("sudo apt-get install -y git-lfs")
 
 
 def clone_taped_test_data_repo(cfg):