Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update maintainers #1000

Merged
merged 2 commits into from
Feb 6, 2025
Merged

Update maintainers #1000

merged 2 commits into from
Feb 6, 2025

Conversation

bjsowa
Copy link
Collaborator

@bjsowa bjsowa commented Jan 26, 2025

No description provided.

sea-bass
sea-bass reviewed Jan 26, 2025
View reviewed changes
Copy link
Contributor

@sea-bass sea-bass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I know Foxglove is not actively maintaining this, but unsure if @achim-k or @jihoonl should be removed at this point.

Tagging them so they can directly answer the question, as I couldn't really approve this change without their consent.

@bjsowa bjsowa requested a review from jihoonl January 26, 2025 14:40
@sea-bass sea-bass requested a review from achim-k January 26, 2025 18:01
@achim-k
Copy link
Contributor

achim-k commented Jan 26, 2025

Hmm, I know Foxglove is not actively maintaining this, but unsure if @achim-k or @jihoonl should be removed at this point.

Yeah, feel free to remove me

@bjsowa
Copy link
Collaborator Author

bjsowa commented Feb 6, 2025

@sea-bass Are we good to merge this ?

sea-bass
sea-bass approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@sea-bass sea-bass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think enough time has passed for active maintainers to respond. Go ahead!

@bjsowa bjsowa merged commit cced3fb into ros2 Feb 6, 2025
6 checks passed
@bjsowa bjsowa deleted the chore/update-maintainers branch February 6, 2025 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtbandes jtbandes jtbandes approved these changes

@sea-bass sea-bass sea-bass approved these changes

@EzraBrooks EzraBrooks Awaiting requested review from EzraBrooks

@MatthijsBurgh MatthijsBurgh Awaiting requested review from MatthijsBurgh

@jihoonl jihoonl Awaiting requested review from jihoonl

@achim-k achim-k Awaiting requested review from achim-k

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bjsowa @achim-k @jtbandes @sea-bass