-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suppress some Mac-specific linker warnings. #5338
Conversation
Contributes to RobotLocomotion#5183.
I just did a clean build on OSX and encountered both "compact unwind" and, surprisingly, "pthread" warnings: https://gist.github.com/liangfok/a4efc3c5cf4400aaa5d14fbc23deb051 I'm surprised because I was fairly sure the pthread warnings were addressed by #5333. Reviewed 1 of 1 files at r1. Comments from Reviewable |
^^^ I'm using 4c12faa. Review status: all files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
Are you sure? I don't see any of those after you do Review status: all files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
I can reproduce the Review status: all files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
Here is an example of the "compact unwind" warning from my gist:
Based on my web browser's search bar, there are 87 instances of it in the gist. Review status: all files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
Oh, sorry, I must have accidentally mixed up two outputs into a single gist. I think you're right. Review status: all files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
+@jwnimmer-tri for platform review. Review status: all files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
Reviewed 1 of 1 files at r1. Comments from Reviewable |
Contributes to #5183.
@liangfok for feature review.
This change is