Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress some Mac-specific linker warnings. #5338

Merged
merged 1 commit into from
Feb 28, 2017

Conversation

david-german-tri
Copy link
Contributor

@david-german-tri david-german-tri commented Feb 27, 2017

Contributes to #5183.

@liangfok for feature review.


This change is Reviewable

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Contributes to RobotLocomotion#5183.
@liangfok
Copy link
Contributor

I just did a clean build on OSX and encountered both "compact unwind" and, surprisingly, "pthread" warnings:

https://gist.github.com/liangfok/a4efc3c5cf4400aaa5d14fbc23deb051

I'm surprised because I was fairly sure the pthread warnings were addressed by #5333.


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@liangfok
Copy link
Contributor

^^^ I'm using 4c12faa.


Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@david-german-tri
Copy link
Contributor Author

encountered both "compact unwind"

Are you sure? I don't see any of those after you do git checkout ct in your gist.


Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@david-german-tri
Copy link
Contributor Author

I can reproduce the pthread warnings. Looking into that now, but it's unrelated to this PR.


Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@liangfok
Copy link
Contributor

Here is an example of the "compact unwind" warning from my gist:

INFO: From Linking drake/solvers/mathematical_program_test:
ld: warning: could not create compact unwind for ___dmumps_parallel_analysis_MOD_dmumps_715: stack subq instruction is too different from dwarf stack size
ld: warning: could not create compact unwind for _write_float: stack subq instruction is too different from dwarf stack size

Based on my web browser's search bar, there are 87 instances of it in the gist.


Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@liangfok
Copy link
Contributor

Oh, sorry, I must have accidentally mixed up two outputs into a single gist. I think you're right. :lgtm:


Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@david-german-tri
Copy link
Contributor Author

+@jwnimmer-tri for platform review.


Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@jwnimmer-tri
Copy link
Collaborator

:lgtm:


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@jwnimmer-tri jwnimmer-tri merged commit 0a58807 into RobotLocomotion:master Feb 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants