Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema: Copy rotation,transform from Anzu #13823

Merged
merged 2 commits into from
Aug 5, 2020

Conversation

jwnimmer-tri
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri commented Aug 5, 2020

Relates #13251.


This change is Reviewable

@jwnimmer-tri
Copy link
Collaborator Author

jwnimmer-tri commented Aug 5, 2020

+@ggould-tri for feature review, please. Note this is all in dev, so does not need platform review. Note that r1 is the file copy, and r2 is the changes for Drake.

Copy link
Contributor

@ggould-tri ggould-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 7 of 7 files at r2.
Reviewable status: labeled "do not merge"

@jwnimmer-tri
Copy link
Collaborator Author

FYI I'm going to use this PR to explore the "curated commits must be based off of the tip of master" interlock in reviewable, so there will be a minor delay before I actually merge this in.

jwnimmer-tri and others added 2 commits August 5, 2020 16:52
Co-authored-by: Grant Gould <ggould@tri.global>
Co-authored-by: Sam Creasey <sam.creasey@tri.global>
Co-authored-by: Siyuan Feng <siyuan.feng@tri.global>
@jwnimmer-tri jwnimmer-tri merged commit f5a8d4b into RobotLocomotion:master Aug 5, 2020
@jwnimmer-tri jwnimmer-tri deleted the transform-dev branch August 5, 2020 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: medium status: commits are properly curated https://drake.mit.edu/reviewable.html#curated-commits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants