common/yaml: Mark private to placate our install #10892
Conversation
Adding a new header dependency involves annotating various release meta-data; we'll defer that to future work, to unbreak macOS CI.
|
+@sammy-tri for all review, please. I've tested on macsim that this fixes the problem. |
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status: all discussions resolved, LGTM missing from assignee sammy-tri, platform LGTM from [ggould-tri] (waiting on @sammy-tri)
There was a problem hiding this comment.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee sammy-tri, platform LGTM from [ggould-tri] (waiting on @jwnimmer-tri and @sammy-tri)
common/yaml/dev/BUILD.bazel, line 16 at r1 (raw file):
drake_cc_package_library( name = "dev", visibility = ["//visibility:private"],
minor: Why is this needed if the default is now private?
There was a problem hiding this comment.
Reviewable status: all discussions resolved, LGTM missing from assignee sammy-tri, platform LGTM from [ggould-tri] (waiting on @sammy-tri)
common/yaml/dev/BUILD.bazel, line 16 at r1 (raw file):
Previously, ggould-tri wrote…
minor: Why is this needed if the default is now private?
OK for better or worse, package_library uses default=public right now, ignoring the BUILD file's default.
|
(I'm happy to do a follow-up issue or PR to help clarify / de-magic the package_library public default.) |
Adding a new header dependency involves annotating various release meta-data; we'll defer that to future work, to unbreak macOS CI.
Closes #10893. Amends #10870. Relates #10869.
This change is