Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Python 3.11 on Mac #248

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

BetsyMcPhail
Copy link
Contributor

@BetsyMcPhail BetsyMcPhail commented Dec 16, 2022

Copy link
Contributor Author

@BetsyMcPhail BetsyMcPhail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@svenevs for review please

Reviewable status: all discussions resolved, LGTM missing from assignee svenevs, platform LGTM missing (waiting on @svenevs)

@svenevs
Copy link
Contributor

svenevs commented Dec 16, 2022

I think we co-merge this with RobotLocomotion/drake#18262. Fix for broken setup is in #250

Copy link
Contributor

@svenevs svenevs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-(status: not ready for review) -(status: not ready to merge) +@rpoyner-tri for platform review please now that CI is confirmed happy.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all discussions resolved, LGTM missing from assignee svenevs, LGTM missing from assignee rpoyner-tri, platform LGTM missing (waiting on @rpoyner-tri)

Copy link
Contributor

@svenevs svenevs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: all discussions resolved, LGTM missing from assignee rpoyner-tri, platform LGTM missing (waiting on @rpoyner-tri)

Copy link
Contributor

@rpoyner-tri rpoyner-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all discussions resolved, platform LGTM from [rpoyner-tri] (waiting on @BetsyMcPhail)

Copy link
Contributor

@rpoyner-tri rpoyner-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently I don't have merge bits for d-e-e. \cc @jwnimmer-tri

Reviewable status: :shipit: complete! all discussions resolved, platform LGTM from [rpoyner-tri] (waiting on @BetsyMcPhail)

@jwnimmer-tri
Copy link
Contributor

jwnimmer-tri commented Feb 14, 2023

Try again now. For some reason, platform reviewers were Maintain instead of Write in the ACLs.

Copy link
Contributor

@rpoyner-tri rpoyner-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all discussions resolved, platform LGTM from [rpoyner-tri] (waiting on @BetsyMcPhail)

Copy link
Contributor

@rpoyner-tri rpoyner-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still getting merge error. 🤷

Reviewable status: :shipit: complete! all discussions resolved, platform LGTM from [rpoyner-tri] (waiting on @BetsyMcPhail)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants