Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add foxglove packages #28

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

wep21
Copy link
Contributor

@wep21 wep21 commented Feb 20, 2025

No description provided.

@wep21 wep21 force-pushed the add-foxglove-packages branch 20 times, most recently from 6571cf0 to ce53750 Compare February 20, 2025 20:02
@wep21
Copy link
Contributor Author

wep21 commented Feb 21, 2025

@traversaro I appreciate it if you could give me any idea to fix foxglove bridge build error on windows.

@traversaro
Copy link
Member

It Is complaining about not finding a missing static constant, right? Unfortunately those are not exported by CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS, you need to manually annotated them, see https://www.kitware.com/create-dlls-on-windows-without-declspec-using-new-cmake-export-all-feature/ .

@wep21 wep21 force-pushed the add-foxglove-packages branch 3 times, most recently from e8f3c3a to d3f178e Compare February 21, 2025 07:34
Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
@wep21 wep21 force-pushed the add-foxglove-packages branch from d3f178e to 6ca6638 Compare February 21, 2025 07:53
@wep21 wep21 marked this pull request as ready for review February 21, 2025 08:06
@wep21
Copy link
Contributor Author

wep21 commented Feb 21, 2025

@traversaro Thanks for your advice. Now ready for review.

@traversaro
Copy link
Member

Thanks! Just for alignment, can you explain if the patch were prepared by you or taken from existing PRs or new versions of the repos? Furthermore, just to make sure, skipping foxglove_compressed_video_transport on Windows is intentional?

@wep21
Copy link
Contributor Author

wep21 commented Feb 21, 2025

can you explain if the patch were prepared by you or taken from existing PRs or new versions of the repos?

I prepared patches by modifying patches in ros-humble.

Furthermore, just to make sure, skipping foxglove_compressed_video_transport on Windows is intentional

yes, because it seems to take some time to fix it.

@wep21 wep21 force-pushed the add-foxglove-packages branch from e47e8b3 to 6ca6638 Compare February 21, 2025 09:14
@traversaro traversaro merged commit 6df315b into RoboStack:main Feb 21, 2025
10 checks passed
@wep21 wep21 deleted the add-foxglove-packages branch February 21, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants