Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to add setting for fixing a seed before execution of f and g f… #4

Merged
merged 2 commits into from
Jan 23, 2020

Conversation

lucidrains
Copy link
Contributor

…unctions

@RobinBruegger @ag1988 Although not elegant, I believe this should fix the problem

@RobinBruegger RobinBruegger merged commit 89cb849 into RobinBruegger:master Jan 23, 2020
@RobinBruegger
Copy link
Owner

Thanks again for the PR @lucidrains . I refactored the code a bit. Functionally, it should be unchanged. Otherwise, please let me know.

I have created version 0.2.2 with this addition.

@lucidrains
Copy link
Contributor Author

@RobinBruegger woohoo! thank you!

@ag1988
Copy link

ag1988 commented Jan 23, 2020 via email

@RobinBruegger
Copy link
Owner

@ag1988 Thanks for reporting that. Turns out I did not turn fix_random_seed on when testing :(
Fixed in v0.2.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants