Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hook Consumer Stateful Widget addition. #20

Merged
merged 9 commits into from
Jan 26, 2022
Merged

Hook Consumer Stateful Widget addition. #20

merged 9 commits into from
Jan 26, 2022

Conversation

rafaelortizzableh
Copy link
Contributor

@rafaelortizzableh rafaelortizzableh commented Jan 25, 2022 •
edited
Loading

  • Created HookStateful Widget shortcut.
  • Added placeholders for widgets' names.
  • Added Constructor with Key to ConsumerStatefulWidget
  • Changed name of Hook Consumer Widget. The new name is Hook Consumer Stateless Widget.

RobertBrunhage
RobertBrunhage requested changes Jan 26, 2022
View reviewed changes
Copy link
Owner

@RobertBrunhage RobertBrunhage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for the contribution!

Could you also:

  1. Add/update the readme with the new snippets
  2. Bump the version to 1.1.0 (Update changelog and package.json)

snippets/consumer_widgets.code-snippets Outdated Show resolved Hide resolved
snippets/hook_consumer.code-snippets Outdated Show resolved Hide resolved
snippets/hook_consumer.code-snippets Outdated Show resolved Hide resolved
RobertBrunhage
RobertBrunhage requested changes Jan 26, 2022
View reviewed changes
Copy link
Owner

@RobertBrunhage RobertBrunhage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two small changes left, looks good otherwise!

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@rafaelortizzableh
Copy link
Contributor Author

Package.json, Changelog and Readme have been updated

rafaelortizzableh and others added 2 commits January 26, 2022 11:55
@rafaelortizzableh @RobertBrunhage
Update CHANGELOG.md
9671587 
Co-authored-by: Robert Brunhage <robertbrunhage@gmail.com>
@rafaelortizzableh @RobertBrunhage
Update CHANGELOG.md
87e25ee 
Co-authored-by: Robert Brunhage <robertbrunhage@gmail.com>
@RobertBrunhage RobertBrunhage merged commit c4449bf into RobertBrunhage:master Jan 26, 2022
@RobertBrunhage
Copy link
Owner

Thanks for the contribution, just merged and is now published as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobertBrunhage RobertBrunhage RobertBrunhage approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rafaelortizzableh @RobertBrunhage