Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial GitHub actions CI #57

Closed
wants to merge 7 commits into from
Closed

Conversation

Robbepop
Copy link
Owner

@Robbepop Robbepop commented May 2, 2020

No description provided.

@coveralls
Copy link

coveralls commented May 2, 2020

Coverage Status

Coverage decreased (-0.4%) to 80.461% when pulling 0571bf7 on add-GitHub-actions-CI into 130949d on master.

@codecov-io
Copy link

codecov-io commented May 2, 2020

Codecov Report

Merging #57 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
- Coverage   80.47%   80.38%   -0.09%     
==========================================
  Files          23       22       -1     
  Lines        5229     5145      -84     
==========================================
- Hits         4208     4136      -72     
+ Misses       1021     1009      -12     
Impacted Files Coverage Δ
src/apint/serde_impl.rs 76.29% <0.00%> (-1.57%) ⬇️
src/radix.rs 88.57% <0.00%> (-0.32%) ⬇️
src/apint/rand_impl.rs 92.20% <0.00%> (-0.30%) ⬇️
src/bitwidth.rs 88.88% <0.00%> (-0.18%) ⬇️
src/apint/utils.rs 79.25% <0.00%> (-0.11%) ⬇️
src/apint/casting.rs 76.29% <0.00%> (-0.11%) ⬇️
src/apint/arithmetic.rs 93.33% <0.00%> (-0.10%) ⬇️
src/apint/constructors.rs 97.44% <0.00%> (-0.08%) ⬇️
src/digit.rs 94.20% <0.00%> (-0.05%) ⬇️
src/apint/to_primitive.rs 96.38% <0.00%> (-0.01%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 130949d...0571bf7. Read the comment docs.

@AaronKutch
Copy link
Contributor

There are some CI related commits currently on the end of PR #56. For the miri and debug tests, we need to add a flag to disable most of the fuzz testing. We don't want to get rid of the fuzz testing completely like the current situation is in #56. I want the fuzz testing to run for a few iterations (I'll figure out the practical numbers in a separate PR for issue #47). For now, I would add a flag such as "expensive_tests" that enables the megafuzz module in arithmetic.rs. I think I should just remove the CI commits from #56 and handle all that here.

Does GitHub actions straight up replace the Appveryor and Travis stuff? I did a small amount of searching, but the way these things interact is still very fuzzy in my mind.

@Robbepop
Copy link
Owner Author

Robbepop commented May 2, 2020

There are some CI related commits currently on the end of PR #56. For the miri and debug tests, we need to add a flag to disable most of the fuzz testing. We don't want to get rid of the fuzz testing completely like the current situation is in #56. I want the fuzz testing to run for a few iterations (I'll figure out the practical numbers in a separate PR for issue #47). For now, I would add a flag such as "expensive_tests" that enables the megafuzz module in arithmetic.rs. I think I should just remove the CI commits from #56 and handle all that here.

Does GitHub actions straight up replace the Appveryor and Travis stuff? I did a small amount of searching, but the way these things interact is still very fuzzy in my mind.

Having miri testing would be a big win to uncover undefined behaviour bugs.
I have not yet figured out how we can get coverage reports to work but I hope I can get it working soon since it is very important imo.
A crate feature to toggle fuzz testing is very important even without CI.

As soon as GitHub actions works we can get rid of Appveyor and Travis CI.

@Robbepop
Copy link
Owner Author

This PR is superseeded by #64. Closed.

@Robbepop Robbepop closed this Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants