-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
blacklist fails to match against a pattern I added #542
Comments
You should use this blacklist entry: |
Yes, that's the entry I used. Sorry for the mixup, I don't know why the asterix characters were removed from my post. probably should've escaped them, somehow. When I hit edit on the OP they're still there. You can see for yourself when you quote reply they're being replaced by underscores. Odd (or not). |
Yeah I see. anything surrounded by asterix is transformed into italic style by githubs markdown. Okay I haven't created an account, but if I just visit https://www.chess.com/game/live/5477498819 with the blacklist entry applied gestures are disabled correctly for me.
I'm also able to do this.
This lets me suspect that when you start playing a new game the website does not change entirely (it basically only changes and loads some new content, but not an entire new page). After that it probably adjusts the URL. In this case Gesturefy would miss that you are on a new URL. Can you confirm this? If this would be the problem I should be able to fix this. |
Confirm this how? I'm not sure what kind of actions/observations you'd like me to perform in order to confirm that? |
Can you send me a short screen recording of the steps you've described above, so I can see when the URL changes in the address bar? You basically can also observe this your own if you look carefully at the browsers reloading symbol. If it does not change shortly to an X symbol after you've started a new game (in other words the browser changed the URL to https://www.chess.com/game/live/XXX) then my assumption is correct. |
Sure, I can do that. Thanks again for looking into it. |
Thanks for the video! Exactly as I've supposed.
Yep, sadly this is not possible on Github. (You can now remove the video or link if you want to)
Not that it matters, but only 5 minutes for a chess round would be way too hectic for me :D |
I won't prioritize this bug if I were you. this is a new game page chess.com is rolling out or, maybe, it's a work in progress. I just played today and the game redirected me to the old game page who's url looks something like this: https://www.chess.com/live?#g=5486375113 and for that page the blacklist rule |
Did you fix it? or, maybe, they made some changes to the page? Either way, after a long while I played some chess, again on chess.com and the blacklist pattern worked. Thanks for looking into this. |
Thanks for the update. I implemented the fix, but it's not shipped yet. They probably changed something on their website. |
Firefox will provide global user controls for site access per add-on. See: - https://bugzilla.mozilla.org/show_bug.cgi?id=1497075 - https://bugzilla.mozilla.org/show_bug.cgi?id=1711787 Removing this option from Gesturefy reduces the amount of code that needs to be maintained. It's also more performant to exclude the entire content script from running than doing content script side checks. Last but not least exclusions have always been a power feature that never really fit into Gesturefy from a design/UI standpoint. Also resolves #542
Describe your matter in detail
This site uses it's own set or right-click gestures which conflict with Gesturefy. Gesturefy overrides the site's features. Yes, I use right-click as the activation button.
How to reproduce:
Fun fact: if I refresh the game page gestures no longer works.
Screenshots or further assistance
Your System
The text was updated successfully, but these errors were encountered: