Ignore bogus advisories #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jderusse some minor adjustments needed, then shippable |
ac791ff to
3c0cb7d
Compare
|
maybe not needed, Github security team might withdraw the 2 advisories. |
xabbuh
referenced
this pull request
in Roave/SecurityAdvisories
Dec 3, 2024
…+00:00" Original commit: "FriendsOfPHP/security-advisories@0386c23"
|
That's generally the best course of action |
|
Thanks @jderusse! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By design, anyone can register a CVE, and sometimes these are false positive. Like the one in cURL https://curl.se/docs/CVE-2023-52071.html
Sadly, it's almost impossible to discard a CVE. This PR aims to ignore a list of advisories in
roave/security-advisories, in a similar way packagist does composer/packagist#1493 and how this repository already patches some entriesSecurityAdvisoriesBuilder/src/Roave/SecurityAdvisories/Rule/RuleProviderFactory.php
Line 43 in d0f7f8f
side note: This PR does not use the
RuleProviderFactorybecause I believe "matching only the package/version" could be an issue: If one day another CVE (a real one) is open with the sameoriginal constraintthe rule will patch it. As a result, the output will miss the original constraint